Fix inconsistent behavior of scalar Jacobi between reference and the others #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhmtsai
added
1:ST:ready-for-review
ginkgo-bot
added
reg:testing
|
@yhmtsai the second commit seems to be missing |
|
@upsj Yes and sorry. I would like to wait for that some jobs of the first commit fail first |
MarcelKoch
approved these changes
Jul 4, 2024
yhmtsai
force-pushed
the
fix_inconsistent_jacobi
branch
from
5176f5b to
7cf1b31
Compare
Co-authored-by: Marcel Koch <marcel.koch@kit.edu>
upsj
approved these changes
Jul 6, 2024
yhmtsai
added
1:ST:ready-to-merge
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1642 +/- ##
========================================
Coverage 91.60% 91.60%
========================================
Files 761 761
Lines 61181 61199 +18
========================================
+ Hits 56045 56064 +19
+ Misses 5136 5135 -1 ☔ View full report in Codecov by Sentry. |
MarcelKoch
pushed a commit
to MarcelKoch/ginkgo
that referenced
this pull request
Dec 2, 2024
This PR fixes inconsistent behavior of scalar Jacobi between reference and the others Related PR: ginkgo-project#1642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the workaround for zero diagonal value in scalar Jacobi, but reference uses 1 but the others uses zero.
I currently make it be 1.
Note. it is not the proper inverse Jacobi matrix.
first commit adds the test and the second one fixes the issue.