Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additive read distributed #1650

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Conversation

fritzgoebel
Copy link
Collaborator

@fritzgoebel fritzgoebel commented Jul 16, 2024

This PR adds an option to communicate overlap in the distributed matrix' read_distributed. If the option is used, nonzero entries present in multiple ranks are added up on the owning rank rather than thrown away in read_distributed.

This can be useful e.g. if in a domain decomposed finite element setting, each rank assembles their local contribution to a global system matrix and when assembling the global system matrix information on the subdomain boundaries has to be exchanged.

TODO:

  • Implement reference kernel tests
  • Implement device kernels
  • Implement device kernel tests

@ginkgo-bot ginkgo-bot added the mod:all This touches all Ginkgo modules. label Jul 16, 2024
@fritzgoebel fritzgoebel added is:new-feature A request or implementation of a feature that does not exist yet. 1:ST:WIP This PR is a work in progress. Not ready for review. type:distributed-functionality labels Jul 16, 2024
@fritzgoebel fritzgoebel force-pushed the additive_read_distributed branch 2 times, most recently from 71c1a41 to 7ab6bf6 Compare July 23, 2024 15:21
@fritzgoebel fritzgoebel self-assigned this Jul 23, 2024
@fritzgoebel fritzgoebel removed the 1:ST:WIP This PR is a work in progress. Not ready for review. label Jul 23, 2024
@fritzgoebel fritzgoebel marked this pull request as ready for review July 23, 2024 15:24
@fritzgoebel fritzgoebel added the 1:ST:ready-for-review This PR is ready for review label Jul 23, 2024
@MarcelKoch MarcelKoch self-requested a review August 8, 2024 11:58
Copy link
Member

@MarcelKoch MarcelKoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly smaller stuff. Only the communication change would be significant, if that would be done.

include/ginkgo/core/distributed/matrix.hpp Outdated Show resolved Hide resolved
core/distributed/matrix.cpp Outdated Show resolved Hide resolved
core/distributed/matrix.cpp Outdated Show resolved Hide resolved
core/distributed/matrix.cpp Show resolved Hide resolved
core/distributed/matrix.cpp Outdated Show resolved Hide resolved
reference/test/distributed/matrix_kernels.cpp Outdated Show resolved Hide resolved
reference/test/distributed/matrix_kernels.cpp Outdated Show resolved Hide resolved
reference/test/distributed/matrix_kernels.cpp Outdated Show resolved Hide resolved
reference/test/distributed/matrix_kernels.cpp Outdated Show resolved Hide resolved
reference/test/distributed/matrix_kernels.cpp Outdated Show resolved Hide resolved
@MarcelKoch MarcelKoch added this to the Ginkgo 1.9.0 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:ready-for-review This PR is ready for review is:new-feature A request or implementation of a feature that does not exist yet. mod:all This touches all Ginkgo modules. type:distributed-functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants