Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable optimized batched solver instantiations #1652

Merged
merged 4 commits into from
Aug 18, 2024

Conversation

pratikvn
Copy link
Member

This PR temporarily disables the instantiations of the different batched solver kernels to reduce compilation time.

@pratikvn pratikvn added 1:ST:ready-for-review This PR is ready for review type:batched-functionality This is related to the batched functionality in Ginkgo labels Jul 23, 2024
@pratikvn pratikvn requested a review from a team July 23, 2024 12:30
@pratikvn pratikvn self-assigned this Jul 23, 2024
@ginkgo-bot ginkgo-bot added mod:core This is related to the core module. mod:cuda This is related to the CUDA module. type:solver This is related to the solvers mod:hip This is related to the HIP module. mod:dpcpp This is related to the DPC++ module. labels Jul 23, 2024
GKO_NOT_IMPLEMENTED;
}
}
// if (sconf.prec_shared) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: IMO it could just be deleted directly, we still have the code in the git log, so it won't be lost. But I'm also fine with leaving it as it is, which probably highlights that it's only temporary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the same way, but since this is temporary, it shouldn't matter much

@yhmtsai
Copy link
Member

yhmtsai commented Aug 5, 2024

It currently forces the behavior.
Because you add the config.hpp, I thought you would like to use config.hpp (configured by CMake) to control the behavior.
Because it is used by some projects, do they use these optimized instantiation?

@pratikvn
Copy link
Member Author

pratikvn commented Aug 5, 2024

Yes, currently we decided to temporarily remove the optimized instantiations. A more permanent solution would be something of the form in #1629

We decided not to go with the config options as that is maybe more annoying for users.

Currently a few projects use the optimized versions, but I think they rely on the previous release, so it should be okay. We will move to the split version soon anyway.

Copy link
Member

@yhmtsai yhmtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The config header is unnecessary now.
How do we ensure the optimized version is still enabled in the next release? maybe make some note in changelog or create an issue until the splitting compilation pr is merged.

core/solver/batch_bicgstab_kernels.hpp Outdated Show resolved Hide resolved
@pratikvn
Copy link
Member Author

pratikvn commented Aug 5, 2024

Created an issue #1661, with the milestone 1.9.0, to track it.

@pratikvn pratikvn added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Aug 16, 2024
@pratikvn pratikvn merged commit 9f1c41b into develop Aug 18, 2024
8 of 14 checks passed
@pratikvn pratikvn deleted the batch-optim branch August 18, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:ready-to-merge This PR is ready to merge. mod:core This is related to the core module. mod:cuda This is related to the CUDA module. mod:dpcpp This is related to the DPC++ module. mod:hip This is related to the HIP module. type:batched-functionality This is related to the batched functionality in Ginkgo type:solver This is related to the solvers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants