-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with distributed preconditioners, add to benchmarks #1660
base: develop
Are you sure you want to change the base?
Conversation
d8f71a7
to
3ee8e1e
Compare
@@ -740,6 +740,11 @@ void Multigrid::generate() | |||
GKO_ASSERT_EQ(level > 0, true); | |||
auto last_mg_level = mg_level_list_.back(); | |||
|
|||
using ws = workspace_traits<Multigrid>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you separate the pr to two? benchmark and the rest.
#ifdef GINKGO_BUILD_MPI | ||
", schwarz-jacobi, schwarz-ilu, schwarz-ic, schwarz-lu, dist-mg" | ||
#endif | ||
""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
""); | |
); |
.on(exec)); | ||
return gko::solver::Multigrid::build() | ||
.with_mg_level(gko::multigrid::Pgm<etype, itype>::build() | ||
.with_deterministic(FLAGS_mg_deterministic)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these flag are not available yet
This PR adds benchmarking support for distributed preconditioners. It also fixes a few things that were causing increased allocations for distributed preconditioners.