Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the casting issue in mixed multigrid #1663

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix the casting issue in mixed multigrid #1663

merged 1 commit into from
Aug 20, 2024

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Aug 6, 2024

The vector e uses the precision of next level, so we can not cast the vector e to the precision of the current level.
We can only do it in the last level because the coarsest solver uses the same precision as the last level.

@yhmtsai yhmtsai added the is:bugfix This fixes a bug label Aug 6, 2024
@yhmtsai yhmtsai requested a review from a team August 6, 2024 09:33
@yhmtsai yhmtsai self-assigned this Aug 6, 2024
@ginkgo-bot ginkgo-bot added mod:core This is related to the core module. type:solver This is related to the solvers labels Aug 6, 2024
@yhmtsai yhmtsai added the 1:ST:ready-for-review This PR is ready for review label Aug 6, 2024
@yhmtsai yhmtsai requested a review from a team August 12, 2024 08:16
@yhmtsai yhmtsai added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Aug 19, 2024
…el precision.

Thus, we can not cast e to current level precision unless it is the last level
@yhmtsai yhmtsai merged commit 9e1c73c into develop Aug 20, 2024
12 of 14 checks passed
@yhmtsai yhmtsai deleted the fix_mixed_mg branch August 20, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:ready-to-merge This PR is ready to merge. is:bugfix This fixes a bug mod:core This is related to the core module. type:solver This is related to the solvers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants