Fix triangular solvers on Windows CUDA #1665
Merged
+122
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
mod:cuda
upsj
commented
Aug 11, 2024
MarcelKoch
approved these changes
Aug 12, 2024
yhmtsai
approved these changes
Aug 12, 2024
upsj
added
1:ST:ready-to-merge
upsj
changed the title
upsj
force-pushed
the
uninitialized_array_alignment
branch
from
acfe081
to
5fb42a1
Compare
MarcelKoch
approved these changes
Aug 12, 2024
thoasm
requested changes
Aug 12, 2024
upsj
removed
the
1:ST:no-changelog-entry
yhmtsai
approved these changes
Aug 13, 2024
Comment on lines
-1226
to
+1230
| return std::isnan(value); | ||
| using std::isnan; | ||
| return isnan(value); |
There was a problem hiding this comment.
is std::isnan(value) different from the updated one?
There was a problem hiding this comment.
I don't think so, but this has a better chance of using the CUDA isnan function.
There was a problem hiding this comment.
unfortunately it still doesn't work with MSVC, which means I'll have to file a bug report some time ;)
thoasm
approved these changes
Aug 13, 2024
Comment on lines
-1226
to
+1230
| return std::isnan(value); | ||
| using std::isnan; | ||
| return isnan(value); |
There was a problem hiding this comment.
I don't think so, but this has a better chance of using the CUDA isnan function.
MSVC doesn't treat the is_nan properly, so we do a byte comparison instead
- move is_nan_exact to internal code - rename to float_to_uint_impl - increase tolerance for additional test
For things to work in Windows, the shared libraries need to be in the working directory or PATH
Co-authored-by: Thomas Grützmacher <thomas.gruetzmacher@tum.de>
upsj
force-pushed
the
uninitialized_array_alignment
branch
from
4734f20
to
95fe3f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alignment of uninitialized_array was currently only 1 based on
unsigned char, and the whole setup screams undefined behavior to me, so this makes it much safer for our current use cases (since casting between complex and real types is well-defined).Additionally, MSVC doesn't properly find
isnanas a device function, so we need to add our own implementation.