Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not-found tbb in the intel github action #1666

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Aug 12, 2024

This pr fixes the not-found tbb module in the intel github action.
The library itself seems to be still available when loading the other intel module.

  • wait for that the intel github action are passed

@yhmtsai yhmtsai added 1:ST:ready-for-review This PR is ready for review 1:ST:skip-full-test 1:ST:no-changelog-entry Skip the wiki check for changelog update labels Aug 12, 2024
@yhmtsai yhmtsai requested a review from a team August 12, 2024 09:43
@yhmtsai yhmtsai self-assigned this Aug 12, 2024
@ginkgo-bot ginkgo-bot added the reg:ci-cd This is related to the continuous integration system. label Aug 12, 2024
@pratikvn
Copy link
Member

So, it is automatically loaded now (within some other package), and still used ? Or not necessary at all ?

@yhmtsai
Copy link
Member Author

yhmtsai commented Aug 12, 2024

@pratikvn I think the dependence is from oneDPL. We do not use them directly, but we need to link it in our CMake.
I can check whether it is still needed now and probably report this.

@yhmtsai
Copy link
Member Author

yhmtsai commented Aug 13, 2024

I have checked the spack installation, the intel-oneapi-mkl package will also install intel-tbb package.
If it does not find the intel-oneapi-tbb, it will use tbb library from intel-tbb.

@yhmtsai yhmtsai force-pushed the fix_intel_githubaction branch 5 times, most recently from b7fbcf1 to 968a626 Compare August 15, 2024 22:31
Comment on lines +50 to +51
export LIBRARY_PATH=${ICL_INTEL_TBB_ROOT}/lib64:${GINKGO_PATH}:$LIBRARY_PATH
export LD_LIBRARY_PATH=${ICL_INTEL_TBB_ROOT}/lib64:${GINKGO_PATH}:$LD_LIBRARY_PATH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit brittle, but as long as it works it's fine with me.
Have you tried using find_package(...) and link_libraries(...) to set the paths instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I agree with you.
No, I haven't. I think it should be done from MKL/DPL if they put it in public linking interface.
There are two package name (for the same thing, AFAIK): TBB from oneMKL (current in machine) and oneTBB from usual setup.

@yhmtsai yhmtsai added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Aug 19, 2024
@yhmtsai yhmtsai merged commit 3bf0ce7 into develop Aug 20, 2024
13 of 14 checks passed
@yhmtsai yhmtsai deleted the fix_intel_githubaction branch August 20, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-to-merge This PR is ready to merge. 1:ST:skip-full-test reg:ci-cd This is related to the continuous integration system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants