-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix not-found tbb in the intel github action #1666
Conversation
So, it is automatically loaded now (within some other package), and still used ? Or not necessary at all ? |
@pratikvn I think the dependence is from oneDPL. We do not use them directly, but we need to link it in our CMake. |
I have checked the spack installation, the intel-oneapi-mkl package will also install intel-tbb package. |
b7fbcf1
to
968a626
Compare
export LIBRARY_PATH=${ICL_INTEL_TBB_ROOT}/lib64:${GINKGO_PATH}:$LIBRARY_PATH | ||
export LD_LIBRARY_PATH=${ICL_INTEL_TBB_ROOT}/lib64:${GINKGO_PATH}:$LD_LIBRARY_PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a bit brittle, but as long as it works it's fine with me.
Have you tried using find_package(...)
and link_libraries(...)
to set the paths instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I agree with you.
No, I haven't. I think it should be done from MKL/DPL if they put it in public linking interface.
There are two package name (for the same thing, AFAIK): TBB from oneMKL (current in machine) and oneTBB from usual setup.
968a626
to
b7aa7d3
Compare
This pr fixes the not-found tbb module in the intel github action.
The library itself seems to be still available when loading the other intel module.