Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler error with nvhpc+mpi #1697

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

MarcelKoch
Copy link
Member

This PR fixes a compiler error from nvhpc, when compiling a mpi test.

Fixes #1638

@MarcelKoch MarcelKoch added this to the Ginkgo 1.9.0 milestone Oct 16, 2024
@MarcelKoch MarcelKoch requested a review from a team October 16, 2024 10:00
@MarcelKoch MarcelKoch self-assigned this Oct 16, 2024
@MarcelKoch MarcelKoch force-pushed the fix-nvhpc-with-mpi-issues branch from 6c26daa to 6618898 Compare October 16, 2024 10:00
Copy link
Member

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this, I remember coming across it a while back, but I didn't remember to fix it then.

yhmtsai
yhmtsai approved these changes Oct 16, 2024
@yhmtsai yhmtsai added the is:bugfix This fixes a bug label Oct 16, 2024
@MarcelKoch MarcelKoch added the 1:ST:ready-to-merge This PR is ready to merge. label Oct 16, 2024
Copy link

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.96%. Comparing base (ca79f34) to head (6618898).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1697      +/-   ##
===========================================
+ Coverage    89.20%   89.96%   +0.76%     
===========================================
  Files          763      763              
  Lines        62970    62878      -92     
===========================================
+ Hits         56171    56571     +400     
+ Misses        6799     6307     -492     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcelKoch MarcelKoch merged commit 532566d into develop Oct 17, 2024
11 of 14 checks passed
@MarcelKoch MarcelKoch deleted the fix-nvhpc-with-mpi-issues branch October 17, 2024 06:56
MarcelKoch added a commit to MarcelKoch/ginkgo that referenced this pull request Dec 2, 2024
This merge fixes a compiler error from nvhpc, when compiling a mpi test.Fix compiler error with nvhpc+mpi.

Related PR: ginkgo-project#1697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:ready-to-merge This PR is ready to merge. is:bugfix This fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ginkgo v1.8.0: test/mpi/matrix.cpp", line 220: error: too many initializer values
3 participants