-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Intel CI jobs on cluster #1723
Conversation
596aad4
to
5a41dbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice you also change some nvidia-gpu jobs, and we are missing cuda 11.0 which is our oldest nvidia compiler support.
Could you also add them back?
# Prevent performance issues with high core counts | ||
set_property(TEST example_${example}_${executor} PROPERTY ENVIRONMENT OMP_NUM_THREADS=4) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be relied on the user or our ctest resource group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the examples are fast enough to not need it. Only with OpenMP I saw parallel examples taking 500s to executing, so this is a simple workaround
122cdea
to
82a740f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. only a nit on the job name
534d174
to
123a9e3
Compare
Otherwise, we get -999 Unknown PI error after second device ref: intel/llvm#10982
123a9e3
to
7e6c81c
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1723 +/- ##
===========================================
- Coverage 90.37% 90.10% -0.28%
===========================================
Files 782 782
Lines 63428 63476 +48
===========================================
- Hits 57325 57193 -132
- Misses 6103 6283 +180 ☔ View full report in Codecov by Sentry. |
Sets tags for CI execution on the Ponte Vecchio node and fixes found issues. Related PR: ginkgo-project#1723
This runs intel CI jobs on the new
gitlab-meta-runner
-driven runners on the cluster