Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Intel CI jobs on cluster #1723

Merged
merged 8 commits into from
Nov 16, 2024
Merged

Run Intel CI jobs on cluster #1723

merged 8 commits into from
Nov 16, 2024

Conversation

upsj
Copy link
Member

@upsj upsj commented Nov 7, 2024

This runs intel CI jobs on the new gitlab-meta-runner-driven runners on the cluster

@ginkgo-bot ginkgo-bot added the reg:ci-cd This is related to the continuous integration system. label Nov 7, 2024
@upsj upsj force-pushed the intel-ci-cluster branch from 596aad4 to 5a41dbc Compare November 7, 2024 20:05
Copy link
Member

@yhmtsai yhmtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice you also change some nvidia-gpu jobs, and we are missing cuda 11.0 which is our oldest nvidia compiler support.
Could you also add them back?

.gitlab/variables.yml Outdated Show resolved Hide resolved
Comment on lines +104 to +105
# Prevent performance issues with high core counts
set_property(TEST example_${example}_${executor} PROPERTY ENVIRONMENT OMP_NUM_THREADS=4)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be relied on the user or our ctest resource group?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the examples are fast enough to not need it. Only with OpenMP I saw parallel examples taking 500s to executing, so this is a simple workaround

.gitlab/image.yml Show resolved Hide resolved
.gitlab/image.yml Outdated Show resolved Hide resolved
@upsj upsj requested a review from yhmtsai November 12, 2024 00:15
@upsj upsj added the 1:ST:no-changelog-entry Skip the wiki check for changelog update label Nov 12, 2024
Copy link
Member

@yhmtsai yhmtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. only a nit on the job name

.gitlab-ci.yml Show resolved Hide resolved
@MarcelKoch MarcelKoch added this to the Ginkgo 1.9.0 milestone Nov 13, 2024
Otherwise, we get -999 Unknown PI error after second device
ref: intel/llvm#10982
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (dc8cfeb) to head (7e6c81c).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1723      +/-   ##
===========================================
- Coverage    90.37%   90.10%   -0.28%     
===========================================
  Files          782      782              
  Lines        63428    63476      +48     
===========================================
- Hits         57325    57193     -132     
- Misses        6103     6283     +180     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@upsj upsj merged commit c051384 into develop Nov 16, 2024
12 of 14 checks passed
@upsj upsj deleted the intel-ci-cluster branch November 16, 2024 21:05
MarcelKoch pushed a commit to MarcelKoch/ginkgo that referenced this pull request Dec 2, 2024
Sets tags for CI execution on the Ponte Vecchio node and fixes found issues.

Related PR: ginkgo-project#1723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:run-full-test reg:ci-cd This is related to the continuous integration system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants