Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable Half in mpi #1759

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

enable Half in mpi #1759

wants to merge 5 commits into from

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Dec 30, 2024

This PR enables half precision in distributed environment by adding custom operation.

one-side operation like accumulation and fetch_and_op does not support custom operation.

Note. Newer version of mpi might support half precision natively (also for one-side operation) if the administrator build it with compiler supporting native half precision and enable the option.

TODO:

  • enable the rest distributed function with half
  • put the custom operation in gko::comm?

@yhmtsai yhmtsai added the 1:ST:WIP This PR is a work in progress. Not ready for review. label Dec 30, 2024
@yhmtsai yhmtsai self-assigned this Dec 30, 2024
@ginkgo-bot ginkgo-bot added reg:testing This is related to testing. type:solver This is related to the solvers type:preconditioner This is related to the preconditioners mod:all This touches all Ginkgo modules. labels Dec 30, 2024
@yhmtsai yhmtsai added 1:ST:ready-for-review This PR is ready for review and removed 1:ST:WIP This PR is a work in progress. Not ready for review. labels Jan 2, 2025
@yhmtsai yhmtsai requested a review from a team January 2, 2025 08:30
@ginkgo-bot
Copy link
Member

Error: The following files need to be formatted:

common/cuda_hip/distributed/assembly_kernels.cpp
common/cuda_hip/distributed/matrix_kernels.cpp
common/cuda_hip/distributed/vector_kernels.cpp
common/unified/distributed/assembly_kernels.cpp
core/device_hooks/common_kernels.inc.cpp
core/distributed/assembly.cpp
core/distributed/helpers.hpp
core/distributed/matrix.cpp
core/distributed/preconditioner/schwarz.cpp
core/distributed/vector.cpp
core/test/mpi/base/bindings.cpp
core/test/utils.hpp
dpcpp/distributed/assembly_kernels.dp.cpp
dpcpp/distributed/matrix_kernels.dp.cpp
dpcpp/distributed/vector_kernels.dp.cpp
include/ginkgo/core/base/mpi.hpp
include/ginkgo/core/distributed/matrix.hpp
include/ginkgo/core/distributed/vector.hpp
omp/distributed/assembly_kernels.cpp
omp/distributed/matrix_kernels.cpp
omp/distributed/vector_kernels.cpp
reference/distributed/assembly_kernels.cpp
reference/distributed/matrix_kernels.cpp
reference/distributed/vector_kernels.cpp
test/mpi/solver/solver.cpp
test/mpi/vector.cpp

You can find a formatting patch under Artifacts here or run format! if you have write access to Ginkgo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:ready-for-review This PR is ready for review mod:all This touches all Ginkgo modules. reg:testing This is related to testing. type:preconditioner This is related to the preconditioners type:solver This is related to the solvers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants