Allow runtime application choice for capture #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergystepanov
force-pushed
the
refactor/abstract-runtime
branch
2 times, most recently
from
26cc0fc
to
29c6d07
Compare
sergystepanov
force-pushed
the
refactor/abstract-runtime
branch
from
9af9da8
to
bf7693c
Compare
sergystepanov
force-pushed
the
refactor/abstract-runtime
branch
from
24ed182
to
5c6978b
Compare
sergystepanov
force-pushed
the
refactor/abstract-runtime
branch
from
fe1c696
to
e82cbe3
Compare
sergystepanov
force-pushed
the
refactor/abstract-runtime
branch
from
e82cbe3
to
13ae330
Compare
sergystepanov
force-pushed
the
refactor/abstract-runtime
branch
from
91e5559
to
7053807
Compare
sergystepanov
force-pushed
the
refactor/abstract-runtime
branch
from
ca5c4c1
to
141f0a4
Compare
In the current version of the application, we have strictly hardcoded the captured runtime application (FFI Libretro frontend) as well as the streaming transport (WebRTC). This commit makes it possible to choose these components at runtime. In this commit, we no longer manage initially connected users separately from the rooms, and instead, we treat all users as abstract app sessions, rather than hardcoded WebRTC connections. These sessions may contain all the transport specifics, such as WebRTC and so on. Rooms, instead of having the hardcoded emulator app and WebRTC media encoders, now have these components decoupled. In theory, it is possible to add new transports (e.g., WebTransport) and streaming apps (e.g., wrapped into an ffmpeg desktop app).
sergystepanov
force-pushed
the
refactor/abstract-runtime
branch
from
141f0a4
to
e3372b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version of the application we have strictly hardcoded captured runtime application (FFI Libretro frontend) with the streaming transport (WebRTC), and this PR is dedicated to the work on making it possible to choose these parts at the compile time (and maybe at the runtime in the future).
In this version, router, which belongs to the worker, now sees initially connected users as abstract app sessions instead of hardcoded WebRTC connections. These sessions may contain all the transport specifics such as WebRTC and so on.
Rooms instead of the hardcoded emulator app and media encoders, now have these parts decoupled also.