Skip to content

Commit

Permalink
Fix code formatting/naming in the docstrings
Browse files Browse the repository at this point in the history
  • Loading branch information
wreise committed Oct 7, 2020
1 parent d4fc997 commit 597b38c
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
6 changes: 6 additions & 0 deletions doc/modules/homology.rst
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ Undirected simplicial homology

Directed simplicial homology
----------------------------
.. currentmodule:: gtda

This comment has been minimized.

Copy link
@ulupo

ulupo Oct 7, 2020

Contributor

Oh dear yes! 👍


.. autosummary::
:toctree: generated/homology/
:template: class.rst

homology.FlagserPersistence

Cubical homology
Expand Down
2 changes: 1 addition & 1 deletion gtda/diagrams/features.py
Original file line number Diff line number Diff line change
Expand Up @@ -697,7 +697,7 @@ def transform(self, X, y=None):
Returns
-------
Xt : ndarray of shape (n_samples, n_homology_dimensions * 2 \
* n_coefficients_)

This comment has been minimized.

Copy link
@ulupo

ulupo Oct 7, 2020

Contributor

@wreise This one was intentional, as we mean the fitted attribute n_coefficients_ rather than the init n_coefficients.

* n_coefficients)
Polynomial coefficients: real and imaginary parts of the complex
polynomials obtained in each homology dimension from each diagram
in `X`.
Expand Down
2 changes: 1 addition & 1 deletion gtda/diagrams/preprocessing.py
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ def transform(self, X, y=None):
Xt : ndarray of shape (n_samples, n_features_filtered, 3)
Filtered persistence diagrams. Only the subdiagrams corresponding
to dimensions in :attr:`homology_dimensions_` are filtered.
``n_features_filtered`` is less than or equal to ``n_features`.
``n_features_filtered`` is less than or equal to ``n_features``.

This comment has been minimized.

Copy link
@ulupo

ulupo Oct 7, 2020

Contributor

Well spotted!

"""
check_is_fitted(self)
Expand Down

0 comments on commit 597b38c

Please sign in to comment.