Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds WeakAlphaPersistence #464

Merged
merged 23 commits into from
Aug 30, 2020
Merged

Adds WeakAlphaPersistence #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
b9eaebe
Code for WeakAlphaPersistence transformer
ulupo Aug 24, 2020
9732452
Style
ulupo Aug 24, 2020
50d14b4
Merge branch 'master' of https://github.com/giotto-ai/giotto-tda into…
ulupo Aug 25, 2020
e47bbaa
Use COO format following fix in #465
ulupo Aug 25, 2020
48a5f0e
Fix import
ulupo Aug 25, 2020
7c8d06a
Remove unnecessary shape setting
ulupo Aug 25, 2020
fb07300
Add docs for WeakAlphaFiltration, linting elsewhere
ulupo Aug 25, 2020
df130b7
Fix docstring for fit and transform in WeakAlphaPersistence
ulupo Aug 25, 2020
6508110
Add WeakAlphaPersistence to See alsos
ulupo Aug 25, 2020
fac5b93
Start adapting VietorisRipsPersistence tests to WeakAlphaPersistence
ulupo Aug 25, 2020
d0673ca
Add WeakAlphaPersistence to API reference and change relative order o…
ulupo Aug 25, 2020
6c5b870
Reinstate explicit shape as it seems required by our version of C++ r…
ulupo Aug 25, 2020
cd35230
Make WeakAlphaPersistence tests which pass
ulupo Aug 25, 2020
cc78060
Add tests of correctness of VietorisRipsPersistence and WeakAlphaPers…
ulupo Aug 25, 2020
2abb2cc
Fix flake8 issues
ulupo Aug 25, 2020
58f597e
Fix error type in test
ulupo Aug 25, 2020
75b3974
Fix dash
ulupo Aug 25, 2020
dc4bb66
Add inline comments
ulupo Aug 25, 2020
b6a9814
Adapt to sklearn 0.23 API in test_common
ulupo Aug 25, 2020
49e7830
Merge branch 'master' into homology/weak_alpha
ulupo Aug 28, 2020
22d6030
Corrections following @gtauzin's review
ulupo Aug 29, 2020
dbf2ef6
Further improve docstrings after @gtauzin's comments by being precise…
ulupo Aug 29, 2020
ca0073f
Improve shape description in plot methods of homology transformers
ulupo Aug 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/modules/homology.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

homology.VietorisRipsPersistence
homology.SparseRipsPersistence
homology.WeakAlphaPersistence
homology.EuclideanCechPersistence
homology.FlagserPersistence
homology.CubicalPersistence
5 changes: 3 additions & 2 deletions gtda/homology/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,14 @@
# License: GNU AGPLv3

from .simplicial import VietorisRipsPersistence, SparseRipsPersistence, \
EuclideanCechPersistence, FlagserPersistence
WeakAlphaPersistence, EuclideanCechPersistence, FlagserPersistence
from .cubical import CubicalPersistence

__all__ = [
'VietorisRipsPersistence',
'SparseRipsPersistence',
'WeakAlphaPersistence',
'EuclideanCechPersistence',
'FlagserPersistence',
'CubicalPersistence',
]
]
2 changes: 1 addition & 1 deletion gtda/homology/cubical.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ def plot(Xt, sample=0, homology_dimensions=None, plotly_params=None):

Parameters
----------
Xt : ndarray of shape (n_samples, n_points, 3)
Xt : ndarray of shape (n_samples, n_features, 3)
Collection of persistence diagrams, such as returned by
:meth:`transform`.

Expand Down
Loading