Update PairwiseDistance docstring for bottleneck distance #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the bottleneck distance when the delta parameter is non-zero
…e_397_update_docstring
rorondre
changed the title
ulupo
added a commit
that referenced
this pull request
Nov 20, 2020
* Add workflow figure to docs (#519) * Add workflow figure to docs * Fix forgotten reshape in MNIST notebook * Add 0.3.0 to the list of versions Co-authored-by: wreise <wojciech.reise@epfl.ch> * Upload new mapper pipeline svg (#521) * Fix copyright notices (#522) * 🎨 Clean up shape classification tutorial (#523) * Add subsection to improve baseline model, remove projective space subsection * Remove case study prefix from Lorenz attractor example Co-authored-by: wreise <wojciech.reise@epfl.ch> Co-authored-by: Umberto Lupo <umberto.lupo@gmail.com> * [CI] Rename notebooks_check to test_notebooks and add test_wheels variable (#524) * Update PairwiseDistance docstring for bottleneck distance (#525) Update the docstring to state what could happen with the symmetry of the bottleneck distance when the delta parameter is non-zero * Bump macOS version in Azure jobs to 10.15 (#527) * Bump macOS version in Azure jobs to 10.15 Attempt to fix the brew woes in the Azure jobs by trying the suggestion in https://developercommunity.visualstudio.com/comments/1239467/view.html * Increase timeout deadline to 500ms in some flaky tests (#531) * Increase timeout deadline to 500ms in collapser and mapper clustering classes tests * Use list comprehensions in _time_delay_embedding * Pull ripser.py latest changes (#530) * Update ripser.py commit * Add robinhhood hashmap as a dependency * Enable use of robinhood hashmap for ripser * Update ccache on azure pipeline Signed-off-by: julian <julian.burellaperez@heig-vd.ch> * Split time series classification notebook into two (#529) * Separate the two notebooks * Rename time_series_classification notebook to topology_time_series * Revert #465 following #530 * Use np.asarray to handle coo attributes being lists * Fix documentation after splitting time series classification notebook (#533) * Add gravitational waves notebook to docs, rename time_series_classification to topology_time_series following #529 * Change link to use cases on giotto.ai * Clarify situation with use cases needing old versions of the library Co-authored-by: Umberto Lupo <umberto.lupo@gmail.com> * Add copyright notice inherited from ripser.py following @MonkeyBreaker's comment * Prepare for v0.3.1 (#534) * Bump version number to 0.3.1 * Make release notes for 0.3.1 and add @rorondre to code authors Co-authored-by: wreise <wojciech.reise@epfl.ch> Co-authored-by: wreise <wojciech.reise@epfl.ch> Co-authored-by: lewtun <lewis.c.tunstall@gmail.com> Co-authored-by: rorondre <r.andreeva@sms.ed.ac.uk> Co-authored-by: REDS institute <reds-heig@users.noreply.github.com> Co-authored-by: Wojciech Reise <32167173+wreise@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issues/PRs
Fixes #397
Types of changes
Description
Small enhancement to PairwiseDistance docstring for bottleneck distance to state what could happen with the symmetry of the bottleneck distance when the delta parameter is non-zero
Screenshots (if appropriate)
Any other comments?
Checklist
flake8to check my Python changes.pytestto check this on Python tests.