Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parameter validation to treat the case where "of" is None #590

Merged
merged 5 commits into from
Jul 8, 2021

Conversation

wreise
Copy link
Collaborator

@wreise wreise commented Jul 5, 2021

Reference issues/PRs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description
The bug #589 is caused by the fact that the validation is attempted, even thought ref_of is None.

Screenshots (if appropriate)

Any other comments?

Checklist

  • I have read the guidelines for contributing.
  • My code follows the code style of this project. I used flake8 to check my Python changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed. I used pytest to check this on Python tests.

@wreise wreise requested a review from ulupo July 5, 2021 09:34
@wreise
Copy link
Collaborator Author

wreise commented Jul 5, 2021

Locally, tests fail on gtda/homology/tests/test_cp_transform.

Copy link
Collaborator

@ulupo ulupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@ulupo ulupo merged commit 1d757d5 into giotto-ai:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Validation of argument 'metric_params' initialized to a dictionary fails when used with a callable metric
2 participants