Fixes simple error in _validate_clusterer #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function for checking if clusterer uses both precomputed affinity and metric (example:sklearn.cluster.AgglomerativeClustering) previously resulted in an error even when not using precomputed metric. This was because the list comprehension to check if there was a precomputed metric parameter resulted in a boolean list instead of a list of parameters set to "precomputed". This small change fixes that bug and ensures the expected behaviour.
|
thank you for your contribution @pujaltes ! I will force merge this PR and try to make sure the CI runs again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issues/PRs
Types of changes
Description
Screenshots (if appropriate)
Any other comments?
Checklist
flake8to check my Python changes.pytestto check this on Python tests.