notify convention need signature after been modified #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbohec
force-pushed
the
174-etq-utilisateur-et-acteur-dune-demande-de-convention-je-reçois-un-mail-spécifique-pour-minformer-que-la-demande-de-convention-a-été-modifiée-par-un-autre-acteur-et-que-je-dois-la-signer-de-nouveau
branch
6 times, most recently
from
76918ff to
40283ad
Compare
|
Make sure that statusJustification is kept on convention modification phase in front.
|
bbohec
force-pushed
the
174-etq-utilisateur-et-acteur-dune-demande-de-convention-je-reçois-un-mail-spécifique-pour-minformer-que-la-demande-de-convention-a-été-modifiée-par-un-autre-acteur-et-que-je-dois-la-signer-de-nouveau
branch
from
2a74b48 to
283f993
Compare
|
Email sample |
JeromeBu
reviewed
Jun 15, 2023
Comment on lines
49
to
52
| if (req.payloads?.backOffice || req.payloads?.convention) { | ||
| return deps.useCases.updateConvention.execute(req.body); | ||
| } | ||
|
|
||
| if (!req.payloads?.convention) throw new UnauthorizedError(); | ||
| return deps.useCases.updateConvention.execute({ | ||
| id: req.payloads.convention.applicationId, | ||
| convention: req.body, | ||
| }); | ||
| throw new UnauthorizedError(); |
There was a problem hiding this comment.
ici c'est un cas où je trouve le if en guard bien plus clair , comme ceci :
// check de droits
if (!req.payloads?.backOffice && !req.payloads?.convention)
throw new UnauthorizedError();
// usecase si tu as le droit
return deps.useCases.updateConvention.execute(req.body);
Comment on lines
+67
to
+74
| const statusJustification = | ||
| params.status === "CANCELLED" || | ||
| params.status === "REJECTED" || | ||
| params.status === "DRAFT" || | ||
| params.status === "DEPRECATED" | ||
| ? params.statusJustification | ||
| : undefined; | ||
|
|
There was a problem hiding this comment.
tu as des utilitaires qui peuvent t'aider dans convention.dto.ts
Genre doesStatusNeedsJustification, ou tout simplement :
Suggested change
| const statusJustification = | |
| params.status === "CANCELLED" || | |
| params.status === "REJECTED" || | |
| params.status === "DRAFT" || | |
| params.status === "DEPRECATED" | |
| ? params.statusJustification | |
| : undefined; | |
| const statusJustification = conventionStatusesWithJustification.includes(params.status) | |
| ? params.statusJustification | |
| : undefined; |
There was a problem hiding this comment.
J'avais essayé mais ça ne passe pas niveau TS. Surement un problème de scope sur le status qui ne s'applique pas sur le reste de la convention.
There was a problem hiding this comment.
essaye doesStatusNeedsJustification je crois bien qu'il y a un type guard
|
|
||
| updateStatus$( | ||
| newConvention$(conventionDto: ConventionDto): Observable<void>; |
There was a problem hiding this comment.
on peut garder le verbe stp: createNewConvention$ ou addNewConvention$
bbohec
force-pushed
the
174-etq-utilisateur-et-acteur-dune-demande-de-convention-je-reçois-un-mail-spécifique-pour-minformer-que-la-demande-de-convention-a-été-modifiée-par-un-autre-acteur-et-que-je-dois-la-signer-de-nouveau
branch
from
bc94195 to
ae3ade8
Compare
JeromeBu
approved these changes
Jun 15, 2023
bbohec
force-pushed
the
174-etq-utilisateur-et-acteur-dune-demande-de-convention-je-reçois-un-mail-spécifique-pour-minformer-que-la-demande-de-convention-a-été-modifiée-par-un-autre-acteur-et-que-je-dois-la-signer-de-nouveau
branch
from
ae3ade8 to
b1f103a
Compare
bbohec
deleted the
174-etq-utilisateur-et-acteur-dune-demande-de-convention-je-reçois-un-mail-spécifique-pour-minformer-que-la-demande-de-convention-a-été-modifiée-par-un-autre-acteur-et-que-je-dois-la-signer-de-nouveau
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.