Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor get last emails #277

Merged
merged 9 commits into from
Jun 12, 2023
Merged

refactor get last emails #277

merged 9 commits into from
Jun 12, 2023

Conversation

JeromeBu
Copy link
Contributor

@JeromeBu JeromeBu commented Jun 9, 2023

  • remove inMemorySentEmail.getLastSentEmail and use notification repository instead
  • fix front with new getLastNotification interface
  • implement Pg get last notifications
  • refactor front to handle corretly sms notifications also
  • rename type to kind in TemplatedEmails
  • fix visualisation of emails with new notifications

front/src/app/pages/admin/EmailsTab.tsx Outdated Show resolved Hide resolved
shared/src/notifications/notifications.schema.ts Outdated Show resolved Hide resolved
shared/src/utils/date.ts Outdated Show resolved Hide resolved
@JeromeBu JeromeBu force-pushed the refactor-get-last-emails branch from bc95d81 to ed1e40a Compare June 12, 2023 09:31
@JeromeBu JeromeBu requested a review from bbohec June 12, 2023 09:37
@JeromeBu JeromeBu enabled auto-merge (rebase) June 12, 2023 09:56
@JeromeBu JeromeBu merged commit 2c29d77 into dev Jun 12, 2023
@JeromeBu JeromeBu deleted the refactor-get-last-emails branch June 12, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants