-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor get last emails #277
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JeromeBu
commented
Jun 9, 2023
- remove inMemorySentEmail.getLastSentEmail and use notification repository instead
- fix front with new getLastNotification interface
- implement Pg get last notifications
- refactor front to handle corretly sms notifications also
- rename type to kind in TemplatedEmails
- fix visualisation of emails with new notifications
bbohec
requested changes
Jun 12, 2023
front/src/core-logic/domain/admin/notifications/notificationsSlice.ts
Outdated
Show resolved
Hide resolved
front/src/core-logic/domain/admin/notifications/notificationsSlice.ts
Outdated
Show resolved
Hide resolved
front/src/core-logic/domain/admin/notifications/notificationsSlice.ts
Outdated
Show resolved
Hide resolved
JeromeBu
force-pushed
the
refactor-get-last-emails
branch
from
June 12, 2023 09:31
bc95d81
to
ed1e40a
Compare
bbohec
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.