refactor(documentation): partie 2, ajout de modèles abstraits pour réduire l'adhérence à machina
#784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentporte
force-pushed
the
765-part2
branch
from
b21a0fe to
0be1eca
Compare
vincentporte
changed the title
documentationmachina
vincentporte
force-pushed
the
765-part2
branch
from
0be1eca to
a1ce345
Compare
vincentporte
force-pushed
the
765-part1
branch
from
b4a0c4f to
eef8d87
Compare
vincentporte
force-pushed
the
765-part2
branch
2 times, most recently
from
ea55cd7 to
a6a67d6
Compare
vincentporte
force-pushed
the
765-part2
branch
from
a6a67d6 to
9e3e12c
Compare
Comment on lines
15
to
31
| migrations.AlterField( | ||
| model_name="partner", | ||
| name="image", | ||
| field=models.ImageField( | ||
| blank=True, | ||
| null=True, | ||
| storage=storages.backends.s3.S3Storage(bucket_name="private-bucket", file_overwrite=False), | ||
| upload_to="", | ||
| validators=[lacommunaute.utils.validators.validate_image_size], | ||
| ), | ||
| ), | ||
| migrations.AlterField( | ||
| model_name="partner", | ||
| name="short_description", | ||
| field=models.CharField(default="to be updated", max_length=400, verbose_name="Short Description"), | ||
| preserve_default=False, | ||
| ), |
There was a problem hiding this comment.
Il y a les partenaires existantes dans la base de données ? Il y aura possiblement des problèmes avec les deux changements :
short_descriptionobligatoire- les images existantes seraient stockées dans le bucket sous
logos/?
There was a problem hiding this comment.
Bon point !
Effectivement, je n'ai pas trouvé comment modifier le bucket_name du champ ImageField herité de Publication.
There was a problem hiding this comment.
pour les partenaires existants, ils ont tous un short_description complété.
vincentporte
force-pushed
the
765-part1
branch
from
eef8d87 to
7fca7f0
Compare
vincentporte
force-pushed
the
765-part2
branch
from
9e3e12c to
bacdf13
Compare
vincentporte
force-pushed
the
765-part1
branch
from
7fca7f0 to
cbfb8a6
Compare
vincentporte
force-pushed
the
765-part2
branch
from
bacdf13 to
020dbe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE #765
Description
🎸 Ajout de modèles abstraits dans
utilsDatedModel, pour réduire les adhérences avecmachinaAbstractPublicationmodèle de contenus éditoriaux : nom, slug, short_description, description en markdown, image) dansutils. Sera réutilisé dans l'appdocumentationet l'apppartnerType de changement
Technique
Points d'attention
🦺 SUITE PR #783
🦺 maintien du nom des variables
createdetupdateddansDatedModelpour simplifier la transposition🦺 réutilisation des modèles abstraits