Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(attachment): affichage des liens vers les fichiers des messages #806

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

vincentporte
Copy link
Contributor

@vincentporte vincentporte commented Nov 8, 2024

Description

🎸 Le templatetag is_available retourne à tord que le fichier n'est pas disponible.
🎸 Remplacer le test par la recherche de la taille du fichier, assorti d'un try/except si le fichier n'est pas trouvé

Type de changement

🪲 Correction de bug (changement non cassant qui corrige un problème).
🚧 technique

Points d'attention

🦺 pourquoi  object.file.field.storage.exists(object.file.name) ne fonctionne pas ou plus ???

Captures d'écran (optionnel)

état actuel non désiré (https://communaute.inclusion.beta.gouv.fr/forum/espace-d%C3%A9changes-113/topic/passage-de-titre-cip-2168/)

image

état desiré

image

@vincentporte vincentporte linked an issue Nov 8, 2024 that may be closed by this pull request
@vincentporte vincentporte added hot fix Pull requests that fix a bug to fix as soon as possible python Pull requests that update Python code labels Nov 8, 2024
@vincentporte vincentporte changed the title fix(attachment): affichage des liens vers les fichiers des messages fix(attachment): affichage des liens vers les fichiers des messages Nov 8, 2024
@vincentporte vincentporte merged commit 7c34605 into master Nov 13, 2024
11 of 13 checks passed
@vincentporte vincentporte deleted the 805-fix-attachment-broken-link branch November 13, 2024 09:33
vincentporte pushed a commit that referenced this pull request Nov 14, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.17.0](v2.16.0...v2.17.0)
(2024-11-14)


### Features

* ajout d'une balise youtube dans le markdown
([#810](#810))
([adbff17](adbff17))
* **forum_conversation:** suppression du triage avant de pouvoir poser
une question
([#818](#818))
([f1b64c6](f1b64c6))
* **stats:** ajout de la colonne categorie dans les stats des fiches
pratiques
([#812](#812))
([c072b5f](c072b5f))
* **user:** authentification via un lien magique envoyé par email
([#804](#804))
([64e04a3](64e04a3))
* **user:** basculer l'authentification vers ProConnect
([#731](#731))
([5429fce](5429fce))


### Bug Fixes

* **attachment:** affichage des liens vers les fichiers des messages
([#806](#806))
([7c34605](7c34605))
* **metabase:** deplanification d'une tâche résiduelle
([#808](#808))
([692a274](692a274))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot fix Pull requests that fix a bug to fix as soon as possible python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix attachment broken link
1 participant