Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajout d'un score de qualité minimum aux requetes data⋅inclusion #5597

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

vperron
Copy link
Contributor

@vperron vperron commented Feb 11, 2025

🤔 Pourquoi ?

L'API data⋅inclusion propose un "score de qualité" qui permet de repérer les services dont les informations ont été remplies "correctement", ce qui va permettre aux consommateurs de l'API de tomber sur des résultats plus qualitatifs/moins frustrants.

Aussi : https://github.com/gip-inclusion/itou-secrets/pull/130

🍰 Comment ?

C'est un query parameter.

🚨 À vérifier

Ni bug ni breaking.

🏝️ Comment tester ?

Pour la recette il faudrait vérifier que le staging des Emplois fait des requetes sur le staging DI, si ce dernier y est branché (tâche pour Victor)

Catégories changelog

Fiches entreprise / Fiches de poste

@vperron vperron self-assigned this Feb 11, 2025
@vperron vperron changed the title Add a minimum quality score to data⋅inclusion API requests Ajout d'un score de qualité minimum aux requetes data⋅inclusion Feb 11, 2025
@vperron vperron added the no-changelog Ne doit pas figurer dans le journal des changements. label Feb 11, 2025
@vperron vperron marked this pull request as ready for review February 12, 2025 11:33
@vperron vperron requested a review from itou-tech February 12, 2025 11:34
Copy link
Contributor

@xavfernandez xavfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça me semble bien mais effectivement ça pourrait être encore mieux de vérifier sur une recette jetable 👍

@vperron vperron added the 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC label Feb 12, 2025
Copy link

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

@vperron
Copy link
Contributor Author

vperron commented Feb 12, 2025

Ca marche bien en local, mais sur la recette jetable c'est une autre paire de manches...

One of the latest additions to the data⋅inclusion API is a quality
score, enabling the API consumer to select only services that respect a
combination of various quality factors.

This ensures the redirected service is not too poorly filled in.
@vperron vperron force-pushed the vperron/min-quality-score branch from 7ae8c41 to e33ded5 Compare February 12, 2025 17:12
@vperron vperron enabled auto-merge February 12, 2025 17:12
@vperron vperron added this pull request to the merge queue Feb 12, 2025
Merged via the queue into master with commit cd6a6a5 Feb 12, 2025
11 checks passed
@vperron vperron deleted the vperron/min-quality-score branch February 12, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC no-changelog Ne doit pas figurer dans le journal des changements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants