Add CI to Build and Publish and Update Documentation #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pp with more examples
64J0
reviewed
Jul 21, 2024
Comment on lines
+18
to
+21
| # GitHub Packages Feed settings | ||
| GITHUB_FEED: https://nuget.pkg.github.com/giraffe-fsharp/ | ||
| GITHUB_USER: dustinmoris | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
I believe it would be beneficial to publish it in the same feed as the other Giraffe packages, but I am open to other suggestions as well.
64J0
approved these changes
Jul 21, 2024
| # Giraffe.OpenApi | ||
|
|
||
| > [!IMPORTANT] | ||
| > This is currently only works with my branch of Giraffe, which can be found [here](https://github.com/mrtz-j/Giraffe/tree/configureEndpoint). | ||
| An extension for the [Giraffe](https://github.com/giraffe-fsharp/Giraffe) Web Application framework with functionality to auto generate OpenApi documentation spec from code. |
dungpa
reviewed
Aug 1, 2024
| Add the `Giraffe.OpenApi` NuGet package to your project: | ||
|
|
||
| ```bash | ||
| dotnet add package Giraffe.OpenApi |
There was a problem hiding this comment.
The PR looks great.
Is there any chance to merge this and publish a Nuget package version of Giraffe.OpenApi?
There was a problem hiding this comment.
Sure, I'm just waiting for another maintainer to approve the PR
There was a problem hiding this comment.
Hi, sorry I was on holiday. Skimmed over it, looks good from afar.
We can always revisit things later if needed.
nojaf
approved these changes
Aug 5, 2024
|
Some leftover problem:
|
|
I'll update the restore-targets and try again in another PR 👍 |
|
I believe some yaml tweak is required before publishing will start to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes some additions and updates to the library. It adds GitHub Actions to the build and publish process, updates the README with proper documentation, and adds more examples to the
SampleApp.It uses the available NuGet ENV-variables to publish it on NuGet under the name
Giraffe.OpenApi.