-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Esy Support #239
Merged
Merged
Esy Support #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnPucciarelli
force-pushed
the
pooch/esy-process
branch
from
May 4, 2020 13:02
8faac87
to
c9629bb
Compare
giraud
reviewed
May 5, 2020
giraud
reviewed
May 5, 2020
giraud
reviewed
May 5, 2020
got
|
giraud
reviewed
May 5, 2020
giraud
reviewed
May 5, 2020
giraud
reviewed
May 5, 2020
giraud
reviewed
May 5, 2020
giraud
reviewed
May 5, 2020
giraud
reviewed
May 5, 2020
…|| FileHelper#isOcaml.
…gs error and returns BsCompiler.
…rking directory on each process recreation.
…-deps and into plugin.xml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the esy panel and commands are really just reusing the dune panel and calling dune commands within the esy sandbox environment.
This PR introduces EsyCompiler and a rewrite of EsyProcess, so that esy no longer relies on any dune component.
Notable Changes:
ORCompilerManager::getCompiler(VirtualFile editorFile)
This method first checks that a file is compilable (.ml, .mli, .re, .rei) and then traverses up the file-system, looking for a a project configuration file (dune, bsconfig.json, package.json) to determine what type of compiler should be invoked to process the file.
Esy Separated from Dune Facet
Esy has been removed from the dune facet configuration. Esy detection is now based on the presence of an esy package.json.
CompilerAction::doAction
This method was broken up into 2 private methods for clarity. One that attempts to compile the active file, if the active file is supported by the compilers. And another that compiles the directory if no active file is present or the active file is unsupported.
Remaining Tasks:
I would like to regression test this branch. Unfortunately, this will have to be done mostly manually. Any regressions will get a test created to prevent it in the future.