Lint pug templates in Vue components #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmullen
force-pushed
the
pug-lint
branch
from
a36eeaf to
114fb1b
Compare
The package update made our linter start catching stuff in the eslintrc file.
|
Sorry for the massive yarn.lock changes, there was a conflict in it, and my answer to yarn.lock conflicts is |
jbeezley
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the vue-cli-service tooling provides no support for linting pug templates, and has no plans to at the moment, though open issues exist, and I imagine it will be added at some point in the future.
I think we should add some third party tooling to support this for the moment. Yes, this adds an annoying amount of dev dependencies and departs slightly from the world of pure first-class vue-supported tools, however I think it's important enough as we gain momentum writing components to justify this.
It's clear that code review time is one of our most limited resources, and we know that using humans as linters in code review is an anti-pattern / bad practice. So with that in mind, I think we should merge this, and open an issue to remove most of this code in the future once pug support gets added to vue tooling.