Skip to content

Commit

Permalink
release.yml: use correct target_commitish arg (#1381)
Browse files Browse the repository at this point in the history
Use the correct name for setting the target of a tag in the release
workflow, for creating a draft release.

It should be `target_commitish` not `tag_commitish`.


https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release

Thanks to @dscho for realising my error.
  • Loading branch information
mjcheetham authored Aug 16, 2023
2 parents 0e54a3e + 0704b42 commit a74fe18
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,7 @@ jobs:
...releaseMetadata,
draft: true,
tag_name: tagName,
tag_commitish: context.sha,
target_commitish: context.sha,
name: `GCM ${version}`
});
releaseMetadata.release_id = createdRelease.data.id;
Expand Down

0 comments on commit a74fe18

Please sign in to comment.