Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Homebrew/homebrew-cask #1102

Closed
8 tasks done
ldennington opened this issue Feb 7, 2023 · 1 comment
Closed
8 tasks done

Migrate to Homebrew/homebrew-cask #1102

ldennington opened this issue Feb 7, 2023 · 1 comment
Assignees
@ldennington
Milestone
Git 2.42

Comments

@ldennington
Copy link
Contributor

ldennington commented Feb 7, 2023 •
edited
Loading

GCM is currently published to a private tap. However, in an effort to standardize macOS installs, we plan to migrate it to the official Homebrew tap for casks (Homebrew/homebrew-cask).

The following are the requirements we believe will need to be fulfilled for this effort:

  • Adhere to the steps outlined in the Cask Cookbook
  • Ensure the new cask works for both x64 and arm64 runtimes
  • Merge PR with new cask into Homebrew/homebrew-cask.
  • Update GCM versioning
  • Update mjcheetham/update-homebrew to update new cask
  • Remove private tap from GCM Homebrew instructions.
  • Add a tap_migrations.json to microsoft/homebrew-git to ensure users are re-directed to the new tap.
  • Update releases to publish to Homebrew/homebrew-cask instead of the private tap.
@ldennington ldennington added this to the Git 2.41 milestone Feb 7, 2023
@ldennington ldennington self-assigned this Feb 7, 2023
@ldennington ldennington added the gcm label Feb 7, 2023
@ldennington ldennington changed the title Migrate to Homebrew/homebrew-cask Migrate to Homebrew/homebrew-core Apr 18, 2023
@ldennington ldennington mentioned this issue Apr 27, 2023
Merged
ldennington added a commit that referenced this issue May 2, 2023
@ldennington
versioning: transition from nerdbank to version file (#1231)
1f7212e 
With the [plan to migrate GCM to a formula for release via
`Homebrew/homebrew-core`](#1102),
it became clear that
[Nerdbank.GitVersioning](https://github.com/dotnet/Nerdbank.GitVersioning)
was no longer an option for versioning the project. This is because
`Nerdbank.GitVersioning` requires history to calculate things like ['Git
height'](https://github.com/dotnet/Nerdbank.GitVersioning#what-is-git-height),
and the formula requires a tarball to build, which, of course, has no
history.

This change pivots GCM to the simpler strategy of using a version
specified in a `VERSION` file at root. This version will be updated by
maintainers prior to release - giving them more granular control of
versioning, which in turn allows for versioning to be more predictable
(i.e. maintainers will know what the version will be before publication
of the release).

The version specified in the file is the one slated for the next
release: `2.1.0.0`.

**Note:** This change [fails on
Windows](https://github.com/ldennington/git-credential-manager/actions/runs/4824686907)
due to a [bug in
MSAL](AzureAD/microsoft-authentication-library-for-dotnet#4108)
unless we ensure all projects have at least 1 dependency. We are working
around this issue by adding Newtonsoft.Json as this dependency (since we
were already shipping it anyway).
@ldennington ldennington modified the milestones: Git 2.41, Git 2.42 May 22, 2023
@keanenwold keanenwold changed the title Migrate to Homebrew/homebrew-core [Epic] Migrate to Homebrew/homebrew-core Jun 12, 2023
@ldennington ldennington changed the title [Epic] Migrate to Homebrew/homebrew-core [Epic] Migrate to Homebrew/homebrew-cask Aug 7, 2023
@ldennington ldennington changed the title [Epic] Migrate to Homebrew/homebrew-cask Migrate to Homebrew/homebrew-cask Aug 10, 2023
@ldennington
Copy link
Contributor Author

Completed with:

@ldennington ldennington mentioned this issue Aug 11, 2023
Merged
ldennington added a commit that referenced this issue Aug 11, 2023
@ldennington
GCM Release 2.3.1 (#1376)
8064e2e 
Changes:

- Ensure only unique accounts are returned from credential store
  - Issue: #1368
  - PR: #1369
- Migrate GCM from `microsoft/homebrew-git` to `Homebrew/homebrew-core`
tap
  - Issue: #1102 
  - PR: #1374
@mjcheetham mjcheetham removed the gcm label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ldennington ldennington

Labels
None yet
Projects
None yet
Milestone
Git 2.42
Development

No branches or pull requests
2 participants
@mjcheetham @ldennington