-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Enterprise redirects to localhost:80
instead of 127.0.0.1:60167
#1329
Comments
Ah, interesting, in that linked change ticket Mislav indicates magic was done to make this work for GitHub CLI.
Perhaps this magic was not repeated on GitHub Enterprise Server for Git Credential Manager? |
Hello! The issue is that the GHES instance has not been updated to register the new IP-loopback redirect URI, but GCM on the client-side is expecting it to have been updated. We must continue to support the previous A workaround to this issue for now is to set the following Git config setting, or the environment variable git config --global credential.gitHubDevRedirectUri "http://localhost/" Note that the trailing slash after |
For github.com we've updated the redirect URI to 127.0.0.1, whilst also keeping the localhost variant around for backwards compatibility with older GCM clients. However, since GHES has not been updated with the new 127.0.0.1 redirect, and older GHES servers will be stuck with the old redirect we must continue to use the localhost redirect on the client for non-dotcom targets. Fixes #1329
We've merged in a fix for this issue to the default branch, and will be available in the next release. A hotfix release is planned imminently. |
Fantastic! Will be checking in this week for updates we can relay to our company. |
**Changes since 2.2.1:** - Fix an issue where duplicate "Personal Access Token" GitHub account options are shown when Visual Studio has a GitHub account signed-in (#1325 #1328) - Fix an issue with Azure DevOps Server (TFS) and Windows Integrated Authentication (#1331 #1332) - Fix an issue with OAuth redirects GitHub Enterprise Server (#1329 #1330) - Correctly handle non-ASCII username/passwords with the WPF UI helpers (#1287 #1326)
Version
2.2.1
Operating system
Windows
OS version or distribution
Windows 11
Git hosting provider(s)
GitHub Enterprise Server
Other hosting provider
GitHub Enterprise Server 3.8.2
(Azure DevOps only) What format is your remote URL?
None
Can you access the remote repository directly in the browser?
Yes, I can access the repository
Expected behavior
Actual behavior
On step 2 the initial GET URL will look like
Note the redirect URL of
http://127.0.0.1:60167
as described in this change. The server will then respond withThe user is unable to log in using OAuth.
Logs
Our current workaround for this is to suggest
Log in with Code
instead.We are currently working to correlate affected users with possible machine configuration issues (many of these folks are web developers) that may be altering local URLs. This issue began this week as folks are updating to the latest version of Git for Windows.
Running
diagnose
andGCM_TRACE=1
did not reveal interesting information, just the tool correctly determining the GHE version and thePat, OAuth
schemes.The text was updated successfully, but these errors were encountered: