Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message handling for LibGit2 #111

Merged
merged 1 commit into from
May 11, 2020
Merged

Fix error message handling for LibGit2 #111

merged 1 commit into from
May 11, 2020

Conversation

mjcheetham
Copy link
Collaborator

Fix the reversed LibGit2 error message handling when no function-name was specified.

@mjcheetham mjcheetham added the bug A bug in Git Credential Manager label May 11, 2020
derrickstolee
derrickstolee approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subtle! Good catch.

@mjcheetham
libgit2: fix error message handling
41d6938 
Fix the reversed LibGit2 error message handling when no function-name
was specified.
@mjcheetham mjcheetham merged commit df61a1e into git-ecosystem:master May 11, 2020
@mjcheetham mjcheetham deleted the fix-lg2error branch May 11, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrickstolee derrickstolee derrickstolee approved these changes

@dscho dscho Awaiting requested review from dscho

@mrfaizal mrfaizal Awaiting requested review from mrfaizal

@jeffhostetler jeffhostetler Awaiting requested review from jeffhostetler

Assignees
No one assigned
Labels
bug A bug in Git Credential Manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjcheetham @derrickstolee