-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for httpCookieFile
#1251
Add support for httpCookieFile
#1251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall! I just added a few minor suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution here! This is great work to see :-)
I've left some comments that will need addressing before we can take the submission however, specifically around more tests for the CurlCookieParser
and making it more robust to invalid or different-cased lines.
based on the review Co-authored-by: Lessley Dennington <ldennington@github.com> Co-authored-by: Matthew John Cheetham <mjcheetham@outlook.com>
based on the review Co-authored-by: Matthew John Cheetham <mjcheetham@outlook.com>
based on the review Co-authored-by: Matthew John Cheetham <mjcheetham@outlook.com>
I modified the code based on your review. (Sorry, I did not understand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff @miya789! Just a few minor suggestions, and I think we will be good to merge! 🎉
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Defaults to true, but overrides even if false Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Thank you for comments, @mjcheetham -san! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work @miya789! Thank you again for the contribution.
We can merge this now.
**Changes:** - Use in-proc methods for getting OS version number (#1240, #1264) - Update System.CommandLine (#1265) - Suppress GUI from command-line argument (#1267) - Add github (login|logout|list) commands (#1267) - cURL Cookie file support (#1251) - Update target framework on Mac/Linux to .NET 7 (#1274, #1282) - Replace JSON.NET with System.Text.Json (#1274) - Preserve exact redirect URI formatting in OAuth requests (#1281) - Use IP localhost redirect for GitHub (#1286) - Use WWW-Authenticate headers from Git for Azure Repos authority (#1288) - Better GitHub Enterprise Managed User (EMU) account support (#1190)
Contents
#1160
I added code to support
httpCookieFile
.If
httpCookieFile
is set ingitconfig
, gcm will add cookie header to request headers such as requests about OAuth2.Note
http.saveCookies
because when it is set, built-in git will update cookie and gcm need not to update.