-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename: remove git-credential-manager-core symlinks #1327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think we can remove some more in Program.cs too.
Also, I wonder if we should update the rename doc to say that the old symlink/name was retired in 2.3.x.
f1b9261
to
1998656
Compare
@mjcheetham - I don't want to be in the same situation we were before where we have a placeholder hanging around. Instead, how about I leave the issue open (I've removed the Fixes from the PR description) until this is released with an outstanding item to update |
Sure, that works too! |
1998656
to
7f70586
Compare
Since 2 versions of Git have released since the rename of the executable from git-credential-manager-core to git-credential-manager, remove the associated symlinks and warnings, (as outlined in docs/rename.md).
7f70586
to
88cae6b
Compare
**Changes since 2.2.2:** - Fix a GCM/Git Trace2 file locking issue - Issue: #1323 - PR: #1340 - Remove symlinks to `git-credential-manager-core` exe - Issue: #1322 - PR: #1327 - Add fallback http uri to `diagnose` command - Issue: #1215 - PR: #1339 - Workaround MSAL tenant issue with silent auth - Issue: #1297 - PR: #1321
Since 2 versions of Git have released since the rename of the executable from
git-credential-manager-core
togit-credential-manager
, remove the associated symlinks and warnings, (as outlined indocs/rename.md
).