Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty string in non-multi dictionary for empty lines #1332

Merged
merged 1 commit into from
Jul 12, 2023

Commits on Jul 12, 2023

  1. streamext: add empty string in non-multi empty lines

    Before 2.2.0, we only accepted input arguments in the form key=value.
    To support the new wwwauth[] argument from Git, we added support for
    these multi-value args key[]=value.
    
    In changing from an dictionary of string:string to string:list<string>
    we accidentally changed the behaviour of dictionary parsing in the case
    that an empty valued argument was provided. For example:
    
    username=\n
    
    Preivously this was returned as an empty string. Post 2.2.0 this became
    `null`, causing an error in scenarios were before there was none.
    
    One such scenario is with Windows Integrated Authentication (for example
    when connecting to Azure DevOps Server/TFS instances), whereby we return
    an empty username and password to Git to signal this auth mode. Git then
    returns to us the empty username and password in a `store` call.
    
    Update the handling in `ParseMultiLine` to restore the previous behaviour
    for empty-valued arguments being mapped to the empty string.
    mjcheetham committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    93cada9 View commit details
    Browse the repository at this point in the history