Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCM 2.3.2 #1380

Merged
merged 5 commits into from
Aug 16, 2023
Merged

GCM 2.3.2 #1380

merged 5 commits into from
Aug 16, 2023

Commits on Aug 14, 2023

  1. Trace2FileWriter: add more general exception

    In #1340, we tried to suppress errors during the modification of a
    trace2 file. However, those exceptions were too specific to the errors I
    had discovered during local testing.
    
    On the 2.3.1 release, I see the following stack error happening:
    
    Unhandled Exception: System.IO.IOException: The process cannot access the file 'C:\Users\dstolee\Downloads\trace.txt' because it is being used by another process.
       at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
       at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
       at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
       at System.IO.StreamWriter.CreateFile(String path, Boolean append, Boolean checkHost)
       at System.IO.StreamWriter..ctor(String path, Boolean append, Encoding encoding, Int32 bufferSize, Boolean checkHost)
       at System.IO.StreamWriter..ctor(String path, Boolean append, Encoding encoding)
       at System.IO.File.InternalAppendAllText(String path, String contents, Encoding encoding)
       at System.IO.File.AppendAllText(String path, String contents)
       at GitCredentialManager.Trace2FileWriter.Write(Trace2Message message)
       ...
    
    This very general 'IOException' catch is necessary to avoid this issue.
    derrickstolee committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    933bb26 View commit details
    Browse the repository at this point in the history
  2. Trace2FileWriter: add more general exception (#1378)

    In #1340, we tried to suppress errors during the modification of a
    trace2 file. However, those exceptions were too specific to the errors I
    had discovered during local testing.
    
    On the 2.3.1 release, I see the following stack error happening:
    
    ```
    Unhandled Exception: System.IO.IOException: The process cannot access the file 'C:\Users\dstolee\Downloads\trace.txt' because it is being used by another process.
       at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
       at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
       at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
       at System.IO.StreamWriter.CreateFile(String path, Boolean append, Boolean checkHost)
       at System.IO.StreamWriter..ctor(String path, Boolean append, Encoding encoding, Int32 bufferSize, Boolean checkHost)
       at System.IO.StreamWriter..ctor(String path, Boolean append, Encoding encoding)
       at System.IO.File.InternalAppendAllText(String path, String contents, Encoding encoding)
       at System.IO.File.AppendAllText(String path, String contents)
       at GitCredentialManager.Trace2FileWriter.Write(Trace2Message message)
       ...
    ```
    
    This very general 'IOException' catch is necessary to avoid this issue.
    derrickstolee authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    adfa71a View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. release.yml: set release tag target in draft

    When creating the initial draft release, also set the target commit to
    the currently built commit (the merge in to `release` typically) so that
    we don't accidentally create a release tag against the wrong target.
    mjcheetham committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    8688f5d View commit details
    Browse the repository at this point in the history
  2. Set release tag target in draft release workflow (#1379)

    When creating the initial draft release, also set the target commit to
    the currently built commit (the merge in to `release` typically) so that
    we don't accidentally create a release tag against the wrong target.
    mjcheetham authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    4561a23 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. version: bump to 2.3.2

    mjcheetham committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    0e54a3e View commit details
    Browse the repository at this point in the history