-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependencies: update to Avalonia 11.0.4 #1383
Conversation
Please don't approve this. I found GCM actually does not exit after GitHub OAuth workflow is complete. |
Thanks for your contribution here!
You are correct. A while ago I had been testing Avalonia using the 11.0 non-preview released bits and found the same issue. For some reason the signal to terminate the platform runloop is not working correctly, although I had confirmed it was being called. I suspect some deadlock, but never had the time to investigate much further. We would ideally like some advice from Avalonia maintainers, on how to use Avalonia in GCM's somewhat strange scenario: Starting as a CLI app, at some point during execution GCM may wish to start up Avalonia and a UI thread. On macOS the UI thread must be the entry thread, so we need to reserve that thread for Avalonia's dispatcher. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing with 'Request changes' to block merge.
I did some investigations and I now believe it is a bug of Avalonia. I have created a PR for Avalonia and it shall fix this issue (I have verified locally on my Macbook). Once it is merged and a new release of Avalonia available, I will bump the version in this PR. |
@mjcheetham Avalonia team really is responsive. My changes got merged and new release 11.0.4 is available. I have bumped the version in this PR and tested locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@de1acr0ix thank you for fixing the Avalonia issue and updating GCM! I've just also confirmed 11.0.4 works perfectly 🎉
There is a change in Avalonia 11 I didn't adopt in this PR. Avalonia 11 can generate |
**Changes:** - Add support for managed identity and service principals in Azure Repos (#1372) - Support universal Gitea OAuth app configuration (#1442) - Set default generic OAuth redirect URI value (#1444) - Drop WPF helpers on Windows (#1417) - Add software rendering override for Windows (#1445, #1453) - Recognise GitLab hosts via WWW-Authenticate header (#1428) - Recognise Bitbucket hosts via WWW-Authenticate header (#1441) - Support GitHub Gist remote URLs (#1402) - Update to Avalonia 11.x (#1383) - Documentation updates (#1416) - Drop unnecessary .NET Framework-specific code (#1447) - Updates to release process (#1386, #1381) - Update code signing certificates (#1431)
**Changes:** _Since 2.4.0:_ - Fix macOS ARM64 tarball contents (#1458) _Since 2.3.x:_ - Add support for managed identity and service principals in Azure Repos (#1372) - Support universal Gitea OAuth app configuration (#1442) - Set default generic OAuth redirect URI value (#1444) - Drop WPF helpers on Windows (#1417) - Add software rendering override for Windows (#1445, #1453) - Recognise GitLab hosts via WWW-Authenticate header (#1428) - Recognise Bitbucket hosts via WWW-Authenticate header (#1441) - Support GitHub Gist remote URLs (#1402) - Update to Avalonia 11.x (#1383) - Documentation updates (#1416) - Drop unnecessary .NET Framework-specific code (#1447) - Updates to release process (#1386, #1381) - Update code signing certificates (#1431)
Update from Avalonia 11.0.0-preview6 to 11.0.4 and fix the codes using APIs removed since 11.0.0 release.