Fix errors with 'git-credential-manager-core configure' with empty config #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
For some situations, the key-value pairs we split from the response of 'git config' do not have two elements. Be careful to check the length before returning the value. If the length is not two, then this is an invalid key-value pair so skip that entry. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
1. When we re-set the configuration, we pass an empty value to clear the existing values. However, that only works if we quote around the empty value. Otherwise, Git does not "see" a value argument. 2. If there is no configuration for a given key, the exit codes for 'git config' change. See the documentation [1] for full details. For now, be careful about exit codes 1 and 5, when appropriate. [1] https://git-scm.com/docs/git-config Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
|
/azp run GCM-PR |
|
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #161. The failures were due to subtleties when working without any
credential.helpervalues in any level of config. This is typical for a fresh install on a Linux machine, but never happens with Git for Windows. Git on macOS might also come pre-loaded with this config.