Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the native macOS ADAL-based Microsoft Authentication component #274

Merged
merged 2 commits into from
Feb 2, 2021

Conversation

mjcheetham
Copy link
Collaborator

Remove the ADAL Objective-C based native authentication component for MSA/AAD. We now rely on the system browser flows within MSAL.NET only (or device code flow). If you're using Chrome or Safari you can also supply the correct Intune management certificate to support device CA policies in AAD.

At the same time remove the ability to use an external authentication helper for Microsoft authentication (AAD/MSA). We now always rely on the in-process MSAL library calls. This extension point was only used by the native helper component anyway.

Remove the ability to use an external authentication helper for
Microsoft authentication (AAD/MSA). We now always rely on the in-process
MSAL library calls.
Remove the ADAL Objective-C based native authentication component for
MSA/AAD. We now rely on the system brower of MSAL.NET.
@mjcheetham mjcheetham added enhancement New feature or request platform:osx Specific to the macOS platform auth:microsoft Specific to Microsoft AAD/MSA authentication labels Feb 2, 2021
Copy link
Contributor

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete all the things!

@mjcheetham mjcheetham merged commit 683c668 into git-ecosystem:master Feb 2, 2021
@mjcheetham mjcheetham deleted the drop-osx-helper branch February 2, 2021 15:23
@mjcheetham mjcheetham mentioned this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth:microsoft Specific to Microsoft AAD/MSA authentication enhancement New feature or request platform:osx Specific to the macOS platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants