Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut new release #300

Merged
merged 71 commits into from
Mar 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
6ec2db2
registry: make GetProvider method async
mjcheetham Jan 12, 2021
8a48eb0
registry: enable registration of providers with priorities
mjcheetham Jan 12, 2021
a73496b
registry: add auto-detection via HTTP query
mjcheetham Jan 12, 2021
c9324de
Fix readme brew uninstall instructions
4brunu Jan 12, 2021
cb0a4d1
Merge pull request #263: Fix readme brew uninstall instructions
derrickstolee Jan 12, 2021
3b54d4e
Add example of how to configure git-credential-core.exe as git's cred…
Jan 13, 2021
a0dc6d5
Docs: Add explanation to git configuration command
johnemau Jan 13, 2021
1fb4d17
Merge pull request #265: [Docs] Add configuration example
derrickstolee Jan 13, 2021
04099e0
Merge pull request #262 from mjcheetham/auto-gh
mjcheetham Jan 15, 2021
2c4bb83
hostregistry: fix bug to ensure correct provider disposal
mjcheetham Feb 1, 2021
f8d7538
msauth: remove ability to use external helper
mjcheetham Feb 1, 2021
3a9232b
osx: remove native MS auth component on macOS
mjcheetham Feb 1, 2021
605912d
Merge pull request #272 from mjcheetham/dispose-fix
mjcheetham Feb 2, 2021
683c668
Merge pull request #274 from mjcheetham/drop-osx-helper
mjcheetham Feb 2, 2021
216b2a8
msauth: return MSAL wrapped result rather than JWT AT
mjcheetham Feb 1, 2021
28fdf76
msauth: rename resource to scopes and drop remote URI
mjcheetham Feb 1, 2021
48c131b
Fix multiple gitHubAuthModes
AlexanderLanin Feb 2, 2021
27c0470
Merge pull request #278 from AlexanderLanin/patch-1
mjcheetham Feb 3, 2021
3e1fbb2
Fix issue in environment doc regarding GitHub auth mode values
mjcheetham Feb 3, 2021
efeb4b3
Fix incorrect value separator in docs for github auth modes
mjcheetham Feb 3, 2021
a9c1810
Merge pull request #277 from mjcheetham/msal-api-harmony
mjcheetham Feb 3, 2021
6161012
fs: pull GCM data directory property up to IFileSystem
mjcheetham Feb 1, 2021
7372874
msauth: update MSAL library version to latest
mjcheetham Feb 1, 2021
10c83a1
msauth: integrate with shared MS dev tool cache on macOS
mjcheetham Feb 1, 2021
66a5731
Merge pull request #275 from mjcheetham/msalcache-osx
mjcheetham Feb 3, 2021
a5d739b
azrepos: add ability to override MSAuth params
mjcheetham Feb 1, 2021
d0fe64e
Merge pull request #279 from mjcheetham/azr-msal-override
mjcheetham Feb 3, 2021
d058996
cmd: use System.CommandLine to parse cmdline args
mjcheetham Feb 1, 2021
5f1c108
cmd: add ability for providers to expose custom cmds
mjcheetham Feb 1, 2021
197817b
Merge pull request #273 from mjcheetham/cmdline
mjcheetham Feb 5, 2021
2384211
docs: update various docs with new code
mjcheetham Feb 8, 2021
5f8b6b4
Merge pull request #282 from mjcheetham/docupdate
mjcheetham Feb 8, 2021
849e169
win: target .NET Framework 4.7.2
mjcheetham Feb 8, 2021
862db15
win: fix installer - include missing binaries
mjcheetham Feb 8, 2021
307e936
Merge pull request #283 from mjcheetham/net472
mjcheetham Feb 10, 2021
ad5eef5
documented behavior under `credential.useHttpPath`
vtbassmatt Feb 11, 2021
1f93592
Update docs/configuration.md
vtbassmatt Feb 12, 2021
1cf480a
Update docs/configuration.md
vtbassmatt Feb 12, 2021
6bbbdd3
Update docs/configuration.md
vtbassmatt Feb 12, 2021
8a699db
Merge pull request #285 from microsoft/docs/useHttpPath
vtbassmatt Feb 12, 2021
296c4bb
created a place for the Helper helper
vtbassmatt Feb 12, 2021
63c7883
move InvokeAsync to the new HelperProcess
vtbassmatt Feb 12, 2021
80bffea
expose the copy of Git we're using
vtbassmatt Feb 12, 2021
fa257ee
rough in changes to talk to credential cache
vtbassmatt Feb 12, 2021
cbc462b
implement credential-cache as
vtbassmatt Feb 12, 2021
b5e7de1
username is the account
vtbassmatt Feb 15, 2021
791173e
whitespace
vtbassmatt Feb 15, 2021
d443baa
elevate Git process creation to the interface
vtbassmatt Feb 16, 2021
aa4c167
put the Git helper code on the Git object
vtbassmatt Feb 16, 2021
97b5593
.NET 5.0
NN--- Feb 16, 2021
77645b1
credential-cache requires EOF on stdin
vtbassmatt Feb 18, 2021
98b1c9a
fail loudly if a test depends on TestGit's process/helper
vtbassmatt Feb 18, 2021
1203cec
pass through options
vtbassmatt Feb 18, 2021
76b34db
document new option
vtbassmatt Feb 18, 2021
adb53cf
don't put CreateProcess on the interface
vtbassmatt Feb 20, 2021
c1a63ba
update all docs
vtbassmatt Feb 20, 2021
3f6b956
use `cache` as the option name
vtbassmatt Feb 20, 2021
eb9405d
a less misleading comment
vtbassmatt Feb 20, 2021
9c6522b
Update link to .NET
NN--- Feb 22, 2021
6ed017e
Update link to .NET documentation
NN--- Feb 22, 2021
e96e689
Merge pull request #287 from microsoft/git-credential-cache
mjcheetham Feb 22, 2021
cd79b90
docs: fix config reference typo
mjcheetham Feb 22, 2021
96944cb
Merge pull request #293: Update link to .NET documentation
derrickstolee Feb 22, 2021
6723971
Merge branch 'master' into net5.0
NN--- Feb 22, 2021
7269802
Merge pull request #288 from NN---/net5.0
mjcheetham Feb 25, 2021
f8581ac
program: fix computation of app path with single file
mjcheetham Feb 25, 2021
10d9d66
Merge pull request #298 from mjcheetham/fix-singlefile-path
mjcheetham Feb 26, 2021
3a35dc5
http: add support for the `NO_PROXY` bypass envar
mjcheetham Mar 1, 2021
1ceb375
docs: fix a typo in the HTTP proxy docs
mjcheetham Mar 1, 2021
8e5abe5
http: allow NO_PROXY split with space
mjcheetham Mar 1, 2021
22fcece
Merge pull request #299 from mjcheetham/noproxy2
mjcheetham Mar 1, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .azure-pipelines/templates/linux/compile.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
steps:
- task: UseDotNet@2
displayName: Use .NET Core SDK 3.1.x
displayName: Use .NET SDK 5.0.x
inputs:
packageType: sdk
version: 3.1.x
version: 5.0.x

- task: DotNetCoreCLI@2
displayName: Compile common code
Expand Down
4 changes: 2 additions & 2 deletions .azure-pipelines/templates/osx/compile.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
steps:
- task: UseDotNet@2
displayName: Use .NET Core SDK 3.1.x
displayName: Use .NET SDK 5.0.x
inputs:
packageType: sdk
version: 3.1.x
version: 5.0.x

- task: DotNetCoreCLI@2
displayName: Compile common code and macOS Helpers
Expand Down
4 changes: 2 additions & 2 deletions .azure-pipelines/templates/osx/pack.signed/step3-pack.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ steps:
downloadPath: '$(Build.StagingDirectory)/payload'

- task: UseDotNet@2
displayName: Use .NET Core SDK 3.1.x
displayName: Use .NET SDK 5.0.x
inputs:
packageType: sdk
version: 3.1.x
version: 5.0.x

- script: dotnet tool install --global nbgv
displayName: Install Nerdbank.GitVersioning tool
Expand Down
2 changes: 1 addition & 1 deletion .azure-pipelines/templates/osx/pack.signed/step5-dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ steps:
artifactName: 'tmp.macsymbols'
downloadPath: '$(Build.StagingDirectory)/symbols'

# Skip notarization until we can preserve the hardened runtime bit and sign the .NET Core runtime bits
# Skip notarization until we can preserve the hardened runtime bit and sign the .NET runtime bits
# Tracked: https://github.com/microsoft/Git-Credential-Manager-Core/issues/108
#- script: src/osx/SignFiles.Mac/notarize-pkg.sh -id "$(AppleId)" -p "$(AppleIdPassword)" -pkg "$(Build.StagingDirectory)"/pkg/*.pkg
# displayName: Notarize and staple installer package
Expand Down
4 changes: 2 additions & 2 deletions .azure-pipelines/templates/windows/compile.signed.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ steps:
signType: '$(SignType)'

- task: UseDotNet@2
displayName: Use .NET Core SDK 3.1.x
displayName: Use .NET SDK 5.0.x
inputs:
packageType: sdk
version: 3.1.x
version: 5.0.x

- task: NuGetToolInstaller@0
displayName: Install NuGet tool >=4.3.0
Expand Down
4 changes: 2 additions & 2 deletions .azure-pipelines/templates/windows/compile.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
steps:
- task: UseDotNet@2
displayName: Use .NET Core SDK 3.1.x
displayName: Use .NET SDK 5.0.x
inputs:
packageType: sdk
version: 3.1.x
version: 5.0.x

- task: DotNetCoreCLI@2
displayName: Restore packages
Expand Down
4 changes: 2 additions & 2 deletions .azure-pipelines/templates/windows/pack.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ steps:
displayName: Set version variables

- script: |
xcopy "out\windows\Installer.Windows\bin\$(configuration)\net461" "$(Build.StagingDirectory)\publish\"
xcopy "out\windows\Payload.Windows\bin\$(configuration)\net461\win-x86" "$(Build.StagingDirectory)\publish\payload\"
xcopy "out\windows\Installer.Windows\bin\$(configuration)\net472" "$(Build.StagingDirectory)\publish\"
xcopy "out\windows\Payload.Windows\bin\$(configuration)\net472\win-x86" "$(Build.StagingDirectory)\publish\payload\"
mkdir "$(Build.StagingDirectory)\publish\payload.sym\"
move "$(Build.StagingDirectory)\publish\payload\*.pdb" "$(Build.StagingDirectory)\publish\payload.sym\"
displayName: Prepare final build artifacts
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-installers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
with:
fetch-depth: 0 # Indicate full history so Nerdbank.GitVersioning works.

- name: Setup .NET Core
- name: Setup .NET
uses: actions/setup-dotnet@v1
with:
dotnet-version: 3.1.302
dotnet-version: 5.0.103

- name: Install dependencies
run: dotnet restore --force
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-signed-deb.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
with:
fetch-depth: 0 # Indicate full history so Nerdbank.GitVersioning works.

- name: Setup .NET Core
- name: Setup .NET
uses: actions/setup-dotnet@v1
with:
dotnet-version: 3.1.302
dotnet-version: 5.0.103

- name: Install dependencies
run: dotnet restore --force
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ jobs:
with:
fetch-depth: 0 # Indicate full history so Nerdbank.GitVersioning works.

- name: Setup .NET Core
- name: Setup .NET
uses: actions/setup-dotnet@v1
with:
dotnet-version: 3.1.302
dotnet-version: 5.0.103

- name: Install dependencies
run: dotnet restore
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ dlldata.c
# Benchmark Results
BenchmarkDotNet.Artifacts/

# .NET Core
# .NET
project.lock.json
project.fragment.lock.json
artifacts/
Expand Down
6 changes: 3 additions & 3 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"request": "launch",
"preLaunchTask": "build",
// If you have changed target frameworks, make sure to update the program path.
"program": "${workspaceFolder}/out/shared/Git-Credential-Manager/bin/Debug/netcoreapp3.1/git-credential-manager-core.dll",
"program": "${workspaceFolder}/out/shared/Git-Credential-Manager/bin/Debug/net5.0/git-credential-manager-core.dll",
"args": ["get"],
"cwd": "${workspaceFolder}/out/shared/Git-Credential-Manager",
"console": "integratedTerminal",
Expand All @@ -22,14 +22,14 @@
"request": "launch",
"preLaunchTask": "build",
// If you have changed target frameworks, make sure to update the program path.
"program": "${workspaceFolder}/out/shared/Git-Credential-Manager/bin/Debug/netcoreapp3.1/git-credential-manager-core.dll",
"program": "${workspaceFolder}/out/shared/Git-Credential-Manager/bin/Debug/net5.0/git-credential-manager-core.dll",
"args": ["store"],
"cwd": "${workspaceFolder}/out/shared/Git-Credential-Manager",
"console": "integratedTerminal",
"stopAtEntry": false,
},
{
"name": ".NET Core Attach",
"name": ".NET Attach",
"type": "coreclr",
"request": "attach",
"processId": "${command:pickProcess}"
Expand Down
13 changes: 0 additions & 13 deletions Git-Credential-Manager.sln
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "GitHub.Tests", "src\shared\
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "osx", "osx", "{3D279E2D-E011-45CF-8EA8-3D71D1300443}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Authentication.Helper.Mac", "src\osx\Microsoft.Authentication.Helper.Mac\Microsoft.Authentication.Helper.Mac.csproj", "{206430B1-CEED-4C84-8D49-D0A399632202}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Installer.Mac", "src\osx\Installer.Mac\Installer.Mac.csproj", "{74FA0AA4-B5C1-4F3B-B182-277FC2D50715}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Installer.Windows", "src\windows\Installer.Windows\Installer.Windows.csproj", "{85903170-9E52-4B53-A6E4-3F416F684FAE}"
Expand Down Expand Up @@ -215,16 +213,6 @@ Global
{3E524EA8-D31A-4394-997C-14B522E3D6FD}.LinuxDebug|Any CPU.Build.0 = Debug|Any CPU
{3E524EA8-D31A-4394-997C-14B522E3D6FD}.LinuxRelease|Any CPU.ActiveCfg = Release|Any CPU
{3E524EA8-D31A-4394-997C-14B522E3D6FD}.LinuxRelease|Any CPU.Build.0 = Release|Any CPU
{206430B1-CEED-4C84-8D49-D0A399632202}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{206430B1-CEED-4C84-8D49-D0A399632202}.MacDebug|Any CPU.ActiveCfg = Debug|Any CPU
{206430B1-CEED-4C84-8D49-D0A399632202}.MacDebug|Any CPU.Build.0 = Debug|Any CPU
{206430B1-CEED-4C84-8D49-D0A399632202}.MacRelease|Any CPU.ActiveCfg = Release|Any CPU
{206430B1-CEED-4C84-8D49-D0A399632202}.MacRelease|Any CPU.Build.0 = Release|Any CPU
{206430B1-CEED-4C84-8D49-D0A399632202}.Release|Any CPU.ActiveCfg = Release|Any CPU
{206430B1-CEED-4C84-8D49-D0A399632202}.WindowsDebug|Any CPU.ActiveCfg = Debug|Any CPU
{206430B1-CEED-4C84-8D49-D0A399632202}.WindowsRelease|Any CPU.ActiveCfg = Release|Any CPU
{206430B1-CEED-4C84-8D49-D0A399632202}.LinuxDebug|Any CPU.ActiveCfg = Debug|Any CPU
{206430B1-CEED-4C84-8D49-D0A399632202}.LinuxRelease|Any CPU.ActiveCfg = Release|Any CPU
{74FA0AA4-B5C1-4F3B-B182-277FC2D50715}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{74FA0AA4-B5C1-4F3B-B182-277FC2D50715}.MacDebug|Any CPU.ActiveCfg = Debug|Any CPU
{74FA0AA4-B5C1-4F3B-B182-277FC2D50715}.MacDebug|Any CPU.Build.0 = Debug|Any CPU
Expand Down Expand Up @@ -343,7 +331,6 @@ Global
{D5277A0E-997E-453A-8CB9-4EFCC8B16A29} = {A7FC1234-95E3-4496-B5F7-4306F41E6A0E}
{3E524EA8-D31A-4394-997C-14B522E3D6FD} = {D5277A0E-997E-453A-8CB9-4EFCC8B16A29}
{3D279E2D-E011-45CF-8EA8-3D71D1300443} = {A7FC1234-95E3-4496-B5F7-4306F41E6A0E}
{206430B1-CEED-4C84-8D49-D0A399632202} = {3D279E2D-E011-45CF-8EA8-3D71D1300443}
{74FA0AA4-B5C1-4F3B-B182-277FC2D50715} = {3D279E2D-E011-45CF-8EA8-3D71D1300443}
{85903170-9E52-4B53-A6E4-3F416F684FAE} = {66722747-1B61-40E4-A89B-1AC8E6D62EA9}
{8DBBAB0A-970D-4BE3-958C-8CDC92F76549} = {66722747-1B61-40E4-A89B-1AC8E6D62EA9}
Expand Down
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ master|[![Build Status](https://mseng.visualstudio.com/AzureDevOps/_apis/build/s

---

[Git Credential Manager Core](https://github.com/microsoft/Git-Credential-Manager-Core) (GCM Core) is a secure Git credential helper built on [.NET Core](https://microsoft.com/dotnet) that runs on Windows and macOS. Linux support is in an early preview.
[Git Credential Manager Core](https://github.com/microsoft/Git-Credential-Manager-Core) (GCM Core) is a secure Git credential helper built on [.NET](https://dotnet.microsoft.com) that runs on Windows and macOS. Linux support is in an early preview.

Compared to Git's [built-in credential helpers]((https://git-scm.com/book/en/v2/Git-Tools-Credential-Storage)) (Windows: wincred, macOS: osxkeychain, Linux: gnome-keyring) which provides single-factor authentication support working on any HTTP-enabled Git repository, GCM Core provides multi-factor authentication support for [Azure DevOps](https://dev.azure.com/), Azure DevOps Server (formerly Team Foundation Server), GitHub, and Bitbucket.

Expand Down Expand Up @@ -69,7 +69,7 @@ If you have an existing installation of the 'Java GCM' on macOS and you have ins
To uninstall, run the following:

```shell
brew cask uninstall git-credential-manager-core
brew uninstall --cask git-credential-manager-core
```

---
Expand Down Expand Up @@ -149,6 +149,8 @@ To uninstall, open Control Panel and navigate to the Programs and Features scree
Git Credential Manager Core is called implicitly by Git, when so configured. It is not intended to be called directly by the user.
For example, when pushing (`git push`) to [Azure DevOps](https://dev.azure.com), a window is automatically opened and an OAuth2 flow is started to get your personal access token.

Read full command line usage [here](docs/usage.md).

### Configuring a proxy

See detailed information [here](https://aka.ms/gcmcore-httpproxy).
Expand Down
Loading