Update IsWslPath to detect \\wsl.localhost-style paths
#612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
added
bug
mjcheetham
requested review from
ldennington,
derrickstolee,
dscho,
jeffhostetler and
vdye
Starting in Windows build 21354, the preferred WSL UNC file path is "\\wsl.localhost\<distro>\" and not the older administrative-share style "\\wsl$\<distro\". The older "wsl$" style will continue to be supported, but won't be the default type of path we'll see from the system going forwards. We now support detecting both styles as WSL paths.
mjcheetham
force-pushed
the
wsl-localhost
branch
from
59ae3dc
to
15a0c7b
Compare
dscho
approved these changes
Jan 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in Windows build 21354, the preferred WSL UNC file path is
\\wsl.localhost\<distro>\and not the older administrative-share style\\wsl$\<distro>\.The older "wsl$" style will continue to be supported, but won't be the default type of path we'll see from the system going forwards.
We now support detecting both styles as WSL paths.
Fixes #611