curl: fix --write-out '%{http_code}'
with Secure Channel
#122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
git update-git-for-windows
command is a Unix Shell script that relies heavily oncurl
; For example, it calls:curl --silent --show-error --output /tmp/gfw-httpget-ruMLqjGG.txt
--write-out '%{http_code}'
https://api.github.com/repos/git-for-windows/git/releases/latest
This worked well until cURL v8.8.0 was integrated. With the Secure Channel backend, the invocation would fail with this error message:
curl: (43) A libcurl function was given a bad argument
The same issue had been reported for a different SSL backend: curl/curl#13845. Conveniently, all we have to do is to Backport the fix from the PR that addressed that ticket to address the bug at hand.
This fixes microsoft/git#655.