Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/deploy: only build mingw-w64-clang for ARM64 #36

Merged
merged 1 commit into from
Jul 2, 2023
Merged

/deploy: only build mingw-w64-clang for ARM64 #36

merged 1 commit into from
Jul 2, 2023

Conversation

rimrul
Copy link
Member

@rimrul rimrul commented Jul 1, 2023

we're not using clang to build for other architectures, so we don't need to build it for other architectures

This is a companion PR to git-for-windows/MINGW-packages#75

@rimrul
/deploy: only build mingw-w64-clang for ARM64
8a1303f 
we're not using clang to build for other architectures, so we don't need
to build it for other architectures

Signed-off-by: Matthias Aßhauer <mha1993@live.de>
dscho
dscho approved these changes Jul 2, 2023
View reviewed changes
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I briefly wondered whether we might want to have a "shrunk" LLVM even for non-ARM builds, just in case we want to switch away from GCC-built Git for Windows, but I guess we can always cross that bridge when (and if!) we get there.

@dscho dscho merged commit 87d45b6 into git-for-windows:main Jul 2, 2023
@rimrul rimrul deleted the mingw-w64-clang-only-arm64 branch July 2, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dscho dscho dscho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rimrul @dscho