Skip to content

Commit

Permalink
Win32: remove separate do_lstat() function
Browse files Browse the repository at this point in the history
With the new mingw_stat() implementation, do_lstat() is only called from
mingw_lstat() (with follow == 0). Remove the extra function and the old
mingw_stat()-specific (follow == 1) logic.

Signed-off-by: Karsten Blees <blees@dcon.de>
  • Loading branch information
kblees authored and dscho committed Sep 18, 2024
1 parent 6cc554f commit bfb6c70
Showing 1 changed file with 2 additions and 20 deletions.
22 changes: 2 additions & 20 deletions compat/mingw.c
Original file line number Diff line number Diff line change
Expand Up @@ -863,14 +863,7 @@ static int has_valid_directory_prefix(wchar_t *wfilename)
return 1;
}

/* We keep the do_lstat code in a separate function to avoid recursion.
* When a path ends with a slash, the stat will fail with ENOENT. In
* this case, we strip the trailing slashes and stat again.
*
* If follow is true then act like stat() and report on the link
* target. Otherwise report on the link itself.
*/
static int do_lstat(int follow, const char *file_name, struct stat *buf)
int mingw_lstat(const char *file_name, struct stat *buf)
{
WIN32_FILE_ATTRIBUTE_DATA fdata;
wchar_t wfilename[MAX_LONG_PATH];
Expand Down Expand Up @@ -904,13 +897,7 @@ static int do_lstat(int follow, const char *file_name, struct stat *buf)
if (handle != INVALID_HANDLE_VALUE) {
if ((findbuf.dwFileAttributes & FILE_ATTRIBUTE_REPARSE_POINT) &&
(findbuf.dwReserved0 == IO_REPARSE_TAG_SYMLINK)) {
if (follow) {
char buffer[MAXIMUM_REPARSE_DATA_BUFFER_SIZE];
buf->st_size = readlink(file_name, buffer, MAXIMUM_REPARSE_DATA_BUFFER_SIZE);
} else {
buf->st_mode = S_IFLNK;
}
buf->st_mode |= S_IREAD;
buf->st_mode = S_IFLNK | S_IREAD;
if (!(findbuf.dwFileAttributes & FILE_ATTRIBUTE_READONLY))
buf->st_mode |= S_IWRITE;
}
Expand Down Expand Up @@ -970,11 +957,6 @@ static int get_file_info_by_handle(HANDLE hnd, struct stat *buf)
return 0;
}

int mingw_lstat(const char *file_name, struct stat *buf)
{
return do_lstat(0, file_name, buf);
}

int mingw_stat(const char *file_name, struct stat *buf)
{
wchar_t wfile_name[MAX_LONG_PATH];
Expand Down

0 comments on commit bfb6c70

Please sign in to comment.