Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data loss when pasting #3936

Closed
1 task
xnoreq opened this issue Jul 5, 2022 · 8 comments · Fixed by git-for-windows/msys2-runtime#45
Closed
1 task

Data loss when pasting #3936

xnoreq opened this issue Jul 5, 2022 · 8 comments · Fixed by git-for-windows/msys2-runtime#45
Labels
msys2
Milestone
v2.37.1

Comments

@xnoreq
Copy link

xnoreq commented Jul 5, 2022

  • I was not able to find an open or closed issue matching what I'm seeing

Setup

$ git --version --build-options

git version 2.37.0.windows.1
cpu: x86_64
built from commit: 989c3a6832b035f6124b0a23da9c0f8f18afa550
sizeof-long: 4
sizeof-size_t: 8
shell-path: /bin/sh
feature: fsmonitor--daemon

$ cmd.exe /c ver

Microsoft Windows [Version 10.0.19044.1806]

$ cat /etc/install-options.txt

Editor Option: Notepad++
Custom Editor Path:
Default Branch Option:
Path Option: Cmd
SSH Option: OpenSSH
Tortoise Option: false
CURL Option: OpenSSL
CRLF Option: CRLFAlways
Bash Terminal Option: MinTTY
Git Pull Behavior Option: Merge
Use Credential Manager: Enabled
Performance Tweaks FSCache: Enabled
Enable Symlinks: Disabled
Enable Pseudo Console Support: Enabled
Enable FSMonitor: Disabled

Details

When running Git Bash or Git CMD,
running

cat > test.txt

and pasting some text like

ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789
ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0132456789

results in garbled output.

I initially thought it's a terminal issue (microsoft/terminal#13422) but it only happens with Git binaries regardless of terminal.
@xnoreq xnoreq changed the title Data Loss when pasting Data loss when pasting Jul 5, 2022
@dscho
Copy link
Member

dscho commented Jul 6, 2022

@xnoreq thank you for contributing this bug report.

Incidentally, the same issue has been reported to the Cygwin mailing list (because the bug is actually in Cygwin's source code), and there are two patches floating about that combined seem to fix the issue. @orgads ran a build, whose artifacts you can download and replacing the usr\bin\msys-2.0.dll file with the version from said artifacts should work around the problem.

@xnoreq if you can verify that this indeed fixes the problem, I will fast-track those patches into the next Git for Windows release.

@xnoreq
Copy link
Author

xnoreq commented Jul 6, 2022

@dscho Yeah that seems to fix the issue.

@rimrul rimrul added the msys2 label Jul 6, 2022
dscho added a commit to dscho/msys2-runtime that referenced this issue Jul 7, 2022
@dscho
Merge branch 'cygwin-3_3-branch'
0cd2c0f 
To allow Git for Windows to enjoy the bug fixes e.g. for
git-for-windows/git#3936 without having to
wait for Cygwin v3.3.6, we merge the current tip of `cygwin-3_3-branch`.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho mentioned this issue Jul 7, 2022
Merged
@dscho
Copy link
Member

dscho commented Jul 7, 2022

@xnoreq could I bother you once more with validating the fix, this time for the artifact from the PR I opened: https://github.com/git-for-windows/msys2-runtime/actions/runs/2632566994#artifacts ?

@dscho dscho added this to the Next release milestone Jul 8, 2022
dscho added a commit to git-for-windows/build-extra that referenced this issue Jul 8, 2022
@dscho
Mention Bug Fix in release notes
9bd1783 
Pasting large amounts of text in Git for Windows' Bash when
running inside Windows Terminal [often resulted in garbled
text](git-for-windows/git#3936), which has
been fixed.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member

dscho commented Jul 8, 2022

I've validated this manually on my side.

@xnoreq
Copy link
Author

xnoreq commented Jul 9, 2022

@dscho Yeah sorry I was busy. I've also rechecked and it looks ok.

@jeremyd2019 jeremyd2019 mentioned this issue Jul 13, 2022
Closed
@goyalyashpal goyalyashpal mentioned this issue Jan 27, 2023
Closed
@goyalyashpal
Copy link

goyalyashpal commented Jan 31, 2023 •
edited
Loading

ran a build, whose artifacts you can download and replacing the usr\bin\msys-2.0.dll file with the version from said artifacts should work around the problem.
- @ dscho at #3936 (comment)

hey, that artifact is expired, how can I rebuild that?

I tried looking at the Workflow file but couldn't figure out. Like what to checkout etc

    steps:
      - name: Checkout code
        uses: actions/checkout@v2

      - name: setup-msys2
        uses: msys2/setup-msys2@v2

Edit: see following:

@orgads
Copy link

orgads commented Jan 31, 2023

It's already included in recent releases. Just install the latest one.

@goyalyashpal
Copy link

i was trying to verify if that build was the one which fixed the issue msys2/MSYS2-packages#3515 or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
msys2
Projects
None yet
Milestone
v2.37.1
Development

Successfully merging a pull request may close this issue.

Pull in fix for pasting more than 1024 characters dscho/msys2-runtime
6 participants
@dscho @orgads @xnoreq @rimrul @goyalyashpal and others