-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup-git-sdk.bat fails in Git For Windows SDK 1.0.1 installer #537
Comments
Hmm. This is obviously 64-bit, but it looks pretty much like the 32-bit problem I worked around in git-for-windows/build-extra@918a119... |
@Astrophizz could you please unpack the SDK manually, change the line 19 from @IF MINGW32 == %MSYSTEM% @( to @IF MINGW64 == %MSYSTEM% @( and then run |
@Astrophizz and if it does not, could you have a look at the ticket @elieux referenced? |
@dscho That worked (editing the line)! Would you like a pull request to remove the check against MINGW32? The next thing that fails in the SDK installer is the installation of 3 packages that don't seem to be in the pacman repo (anymore?):
I've opened an issue at #548. |
No, this was just a work-around. The real fix is to remove the extra level testing for MINGW32. If you could open a Pull Request with that change (with a good commit message, please), that would be awesome! |
Right, that's what I meant. I'll try to get that ready soon. After generating a 7z installer for #548 it occurred to me to test this fix from an installer and, sadly, it still fails in that context. Extracting the archive and running |
I guess it might have something to do with the |
I've made a pull request with #90. |
This topic branch brings various fixes/improvements to the SDK installer so that we can release a new SDK installer, which in turn addresses git-for-windows/git#537 and git-for-windows/git#630 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The installer fails in setup-git-sdk.bat with this written to the terminal:
which would appear to come from this line:
@"%cwd%"\usr\bin\pacman -Sy --needed --force --noconfirm msys2-runtime
Here is the stack trace mentioned by the error output, if it's any use:
Running the pacman command by hand after the fact appears to work fine:
I've reproduced this on two different machines. Both have Windows 10 x64 with the recent, large "Version 1511" November update applied.
The text was updated successfully, but these errors were encountered: