Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch-pack.c: enable fscache for stats under .git/objects #1426

Merged
merged 1 commit into from
Jan 12, 2018
Merged

fetch-pack.c: enable fscache for stats under .git/objects #1426

merged 1 commit into from
Jan 12, 2018

Conversation

atetubou
Copy link

When I do git fetch, git call file stats under .git/objects for each
refs. This takes time when there are many refs.

By enabling fscache, git takes file stats by directory traversing and that
improved the speed of fetch-pack for repository having large number of
refs.

In my windows workstation, this improves the time of git fetch for
chromium repository like below. I took stats 3 times.

  • With this patch
    TotalSeconds: 9.9825165
    TotalSeconds: 9.1862075
    TotalSeconds: 10.1956256
    Avg: 9.78811653333333

  • Without this patch
    TotalSeconds: 15.8406702
    TotalSeconds: 15.6248053
    TotalSeconds: 15.2085938
    Avg: 15.5580231

Signed-off-by: Takuto Ikuta tikuta@chromium.org

fetch-pack.c: enable fscache for stats under .git/objects
0323774 
When I do git fetch, git call file stats under .git/objects for each
refs. This takes time when there are many refs.

By enabling fscache, git takes file stats by directory traversing and that
improved the speed of fetch-pack for repository having large number of
refs.

In my windows workstation, this improves the time of `git fetch` for
chromium repository like below. I took stats 3 times.

* With this patch
TotalSeconds: 9.9825165
TotalSeconds: 9.1862075
TotalSeconds: 10.1956256
Avg: 9.78811653333333

* Without this patch
TotalSeconds: 15.8406702
TotalSeconds: 15.6248053
TotalSeconds: 15.2085938
Avg: 15.5580231

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
@atetubou
Copy link
Author

This is reland of #1372
But for faster stats of loose object files under .git/objects, not to cache stats under .git/objects/pack

@dscho dscho merged commit d0192a7 into git-for-windows:master Jan 12, 2018
@dscho
Copy link
Member

dscho commented Jan 12, 2018

Thanks, looks good!

@atetubou atetubou deleted the fetch_pack branch January 16, 2018 12:37
dscho added a commit that referenced this pull request Jan 18, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
44db187 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 20, 2018
Merge pull request #1426 from atetubou/fetch_pack
ad72ef3 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 22, 2018
Merge pull request #1426 from atetubou/fetch_pack
4483849 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Jan 22, 2018
Merge pull request #1426 from atetubou/fetch_pack
cc315db 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Jan 22, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
6863db1 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Feb 16, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
7f5be18 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Mar 23, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
2f9960b 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Apr 3, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
8915bcf 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request May 29, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
1b4ff21 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request May 29, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
732f6a8 
fetch-pack.c: enable fscache for stats under .git/objects
PKRoma pushed a commit to PKRoma/git-for-windows that referenced this pull request Jun 22, 2018
@dscho
Merge pull request git-for-windows#1426 from atetubou/fetch_pack
ab43a7a 
fetch-pack.c: enable fscache for stats under .git/objects
PKRoma pushed a commit to PKRoma/git-for-windows that referenced this pull request Jun 22, 2018
@dscho
Merge pull request git-for-windows#1426 from atetubou/fetch_pack
596f1d4 
fetch-pack.c: enable fscache for stats under .git/objects
PKRoma pushed a commit to PKRoma/git-for-windows that referenced this pull request Jun 22, 2018
@dscho
Merge pull request git-for-windows#1426 from atetubou/fetch_pack
79c5bd6 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Aug 22, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
a22e43c 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit to dscho/git that referenced this pull request Aug 22, 2018
@dscho
Merge pull request git-for-windows#1426 from atetubou/fetch_pack
12e9479 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Aug 23, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
8fea209 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Aug 23, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
ea252ec 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Aug 23, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
b51dba0 
fetch-pack.c: enable fscache for stats under .git/objects
jamill pushed a commit to jamill/git that referenced this pull request Aug 28, 2018
@dscho @jamill
Merge pull request git-for-windows#1426 from atetubou/fetch_pack
3c23af0 
fetch-pack.c: enable fscache for stats under .git/objects
jamill pushed a commit to jamill/git that referenced this pull request Sep 5, 2018
@dscho @jamill
Merge pull request git-for-windows#1426 from atetubou/fetch_pack
ddac87d 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Sep 10, 2018
@dscho
Merge pull request #1426 from atetubou/fetch_pack
be1f8e4 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Oct 11, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
7a43738 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Oct 20, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
ad4a9ac 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Oct 20, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
65443be 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Oct 21, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
a7c50c4 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Oct 21, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
e3b7b83 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Oct 21, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
2bcc4d8 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Oct 22, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
f8fc5f8 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Oct 22, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
394f958 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Oct 22, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
08d1f77 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Oct 22, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
84d4a35 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Oct 22, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
d623f92 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Oct 22, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
8baafa0 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Oct 23, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
571ea53 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Oct 25, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
52ce510 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Oct 25, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
5e72f5f 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Oct 25, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
1ed6dac 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Oct 30, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
7b2fcdb 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Nov 1, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
4ef0178 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Nov 6, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
c8ad7f1 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Nov 22, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
7527d4f 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Nov 22, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
e8e430f 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Nov 22, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
b4d7624 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Nov 22, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
14cf516 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit that referenced this pull request Nov 22, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
5c24b26 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Nov 25, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
0f34a24 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Nov 25, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
4220090 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Nov 25, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
adcf1b7 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Nov 25, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
68583a3 
fetch-pack.c: enable fscache for stats under .git/objects
dscho added a commit to dscho/git that referenced this pull request Nov 25, 2024
@dscho
Merge pull request git-for-windows#1426 from atetubou/fetch_pack
cc8732d 
fetch-pack.c: enable fscache for stats under .git/objects
git-for-windows-ci pushed a commit that referenced this pull request Nov 25, 2024
@dscho
Merge pull request #1426 from atetubou/fetch_pack
2100d88 
fetch-pack.c: enable fscache for stats under .git/objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atetubou @dscho