Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the filesystem cache (fscache) in refresh_index(). #1827

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Enable the filesystem cache (fscache) in refresh_index(). #1827

merged 1 commit into from
Sep 27, 2018

Conversation

benpeart
Copy link

On file systems that support it, this can dramatically speed up operations
like add, commit, describe, rebase, reset, rm that would otherwise have to
lstat() every file to "re-match" the stat information in the index to that
of the file system.

On a synthetic repo with 1M files, "git reset" dropped from 52.02 seconds to
14.42 seconds for a savings of 72%.

Signed-off-by: Ben Peart Ben.Peart@microsoft.com

On file systems that support it, this can dramatically speed up operations
like add, commit, describe, rebase, reset, rm that would otherwise have to
lstat() every file to "re-match" the stat information in the index to that
of the file system.

On a synthetic repo with 1M files, "git reset" dropped from 52.02 seconds to
14.42 seconds for a savings of 72%.

Signed-off-by: Ben Peart <Ben.Peart@microsoft.com>
@dscho dscho self-requested a review September 27, 2018 15:32
@dscho
Copy link
Member

dscho commented Sep 27, 2018

I like where this is going, but this kind of change already caused one serious regression that had to be reverted in one big hurry. So I would like to spend some quality time reviewing this in-depth, and I will most likely find time to do that toward the end of next week.

@@ -1547,6 +1548,7 @@ int refresh_index(struct index_state *istate, unsigned int flags,

replace_index_entry(istate, i, new_entry);
}
enable_fscache(0);

This comment was marked as off-topic.

@dscho dscho added this to the v2.19.0(2) milestone Sep 27, 2018
@dscho dscho merged commit ba593a7 into git-for-windows:master Sep 27, 2018
dscho added a commit to git-for-windows/build-extra that referenced this pull request Sep 27, 2018
When FSCache is enabled, commands such as
`add`, `commit, and `reset` [are now much
faster](git-for-windows/git#1827).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this pull request Oct 10, 2018
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit to dscho/git that referenced this pull request Oct 12, 2018
…_index

Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit that referenced this pull request Oct 12, 2018
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit to dscho/git that referenced this pull request Nov 19, 2018
…_index

Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit to dscho/git that referenced this pull request Nov 20, 2018
…_index

Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit that referenced this pull request Nov 21, 2018
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit to dscho/git that referenced this pull request Nov 23, 2018
…_index

Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit to dscho/git that referenced this pull request Nov 30, 2018
…_index

Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit to dscho/git that referenced this pull request Dec 1, 2018
…_index

Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit to dscho/git that referenced this pull request Dec 9, 2018
…_index

Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit to dscho/git that referenced this pull request Dec 15, 2018
…_index

Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit that referenced this pull request Sep 26, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit that referenced this pull request Sep 26, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit that referenced this pull request Sep 26, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit that referenced this pull request Sep 27, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit to dscho/git that referenced this pull request Oct 3, 2024
…_index

Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit to dscho/git that referenced this pull request Oct 4, 2024
…_index

Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci pushed a commit that referenced this pull request Oct 4, 2024
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci pushed a commit that referenced this pull request Oct 4, 2024
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci pushed a commit that referenced this pull request Oct 4, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit to dscho/git that referenced this pull request Oct 8, 2024
…_index

Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci pushed a commit that referenced this pull request Oct 8, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit that referenced this pull request Oct 8, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit that referenced this pull request Oct 8, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit that referenced this pull request Oct 8, 2024
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci pushed a commit that referenced this pull request Oct 9, 2024
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci pushed a commit that referenced this pull request Oct 9, 2024
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci pushed a commit that referenced this pull request Oct 9, 2024
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci pushed a commit that referenced this pull request Oct 9, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit that referenced this pull request Oct 9, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit that referenced this pull request Oct 9, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit that referenced this pull request Oct 10, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit that referenced this pull request Oct 10, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit that referenced this pull request Oct 10, 2024
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci pushed a commit that referenced this pull request Oct 10, 2024
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci pushed a commit that referenced this pull request Oct 10, 2024
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci pushed a commit that referenced this pull request Oct 11, 2024
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci pushed a commit that referenced this pull request Oct 11, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit that referenced this pull request Oct 11, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit that referenced this pull request Oct 11, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho added a commit that referenced this pull request Oct 11, 2024
Enable the filesystem cache (fscache) in refresh_index().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants