http: add support selecting http version #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually we don't need to set libcurl to choose which version of the HTTP protocol to use to communicate with a server. But different versions of libcurl, the default value is not the same. CURL >= 7.62.0: CURL_HTTP_VERSION_2TLS CURL < 7.62: CURL_HTTP_VERSION_1_1 In order to give users the freedom to control the HTTP version, we need to add a setting to choose which HTTP version to use. Signed-off-by: Force Charlie <charlieio@outlook.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
derrickstolee
approved these changes
Dec 6, 2018
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Dec 6, 2018
The desired HTTP version (HTTP/2 or HTTP/1.1) [can now be configured via the `http.version` setting](git-for-windows/git#1968). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 6, 2018
http: add support selecting http version
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 9, 2018
http: add support selecting http version
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 15, 2018
http: add support selecting http version
dscho
added a commit
to dscho/git
that referenced
this pull request
Feb 7, 2019
http: add support selecting http version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of git@d73019feb44b (which made it already to
next). It allows settinghttp.versiontoHTTP/1.1orHTTP/2to choose the version of the HTTP protocol to use.This might be important e.g. to let users choose to downgrade to HTTP/1.1 when the desired authentication scheme is incompatible with HTTP/2 (such is the case for NTLM, but we already have a cURL-side patch for that in the pipeline: curl/curl#3345).