Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cygwin: pipe: Restore blocking mode of read pipe on close() #72

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Cygwin: pipe: Restore blocking mode of read pipe on close() #72

merged 1 commit into from
Sep 15, 2024

Commits on Sep 2, 2024

  1. Cygwin: pipe: Restore blocking mode of read pipe on close() 

    If a cygwin app is executed from a non-cygwin app and the cygwin
app exits, read pipe remains on non-blocking mode because of the
commit fc691d0246b9. Due to this behaviour, the non-cygwin app
cannot read the pipe correctly after that. With this patch, the
blocking mode of the read pipe is stored into was_blocking_read_pipe
on set_pipe_non_blocking() when the cygwin app starts and restored
on close().

Addresses: git-for-windows/git#5115
Fixes: fc691d0246b9 ("Cygwin: pipe: Make sure to set read pipe non-blocking for cygwin apps.");
Reported-by: isaacag, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Reported-at: git-for-windows/git#5115
Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @tyan0 @dscho
    tyan0 authored and dscho committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    acc7134 View commit details
    Browse the repository at this point in the history