Added possibility to use secure hashes to store passwords #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With which setup did you test this? OS, Java vendor and version? |
|
Linux (Fedora), openjdk-8 |
|
Okay, thanks.
I have started to integrate your changes, but will have/want to rewrite
them some.
|
|
Not as soon as I thought, but finally verified: Windows 7/Oracle JRE 7 is woking fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1166
PBKDF2WithHmacSHA256 is used instead of MD5.
https://www.owasp.org/index.php/Hashing_Java was used as a reference for the implementation