Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config to disable generating PR title and body from commit #2870

Open
krlvi opened this issue Feb 22, 2024 · 7 comments
Open

Add a config to disable generating PR title and body from commit #2870

krlvi opened this issue Feb 22, 2024 · 7 comments
Assignees
Labels
enhancement An improvement to an existing feature UX/UI Focusing on user satisfaction, usability, and overall experience

Comments

@krlvi
Copy link
Member

krlvi commented Feb 22, 2024

We want to have a config to disable #2835

Discord thread: https://discord.com/channels/1060193121130000425/1210171236630659072/1210208452002058291

@mtsgrd
Copy link
Contributor

mtsgrd commented Feb 22, 2024

Let's say you have this feature turned on, should we rather take the PR title from the branch title instead of taking from the commit? I've used this a few times now and it doesn't feel quite right as it is now.

@mtsgrd mtsgrd self-assigned this Feb 22, 2024
@Pranav2612000
Copy link
Contributor

Pranav2612000 commented Feb 22, 2024

I'll love to pick this up ( or help ) as well. I also created a related #2881 issue.
Where do we want to add the config?

@Pranav2612000
Copy link
Contributor

Pranav2612000 commented Feb 22, 2024

Let's say you have this feature turned on, should we rather take the PR title from the branch title instead of taking from the commit? I've used this a few times now and it doesn't feel quite right as it is now.

Even if the PR has just 1 commit? The current behaviour is what Github also does and I find it to be intuitive for single commits. Doesn't make sense when there are more than 1 commit.

Is there a way to take or poll or something on what most developers prefer?

@mtsgrd
Copy link
Contributor

mtsgrd commented Feb 23, 2024

Right, the reason I am questioning the PR title is because in GitButler you likely already have a title for the branch, which you don't have when creating them from branches using the CLI or in GitHub. What do you think?

About the location, this should likely go under under "git stuff" in gitbutler-ui/src/routes/settings/+page.svelte.

Let me know if you need any help? I'll assign this ticket to you. :)

image

@Pranav2612000
Copy link
Contributor

Pranav2612000 commented Feb 25, 2024

Right, the reason I am questioning the PR title is because in GitButler you likely already have a title for the branch, which you don't have when creating them from branches using the CLI or in GitHub.

Yeah. It makes sense. If we already have a title for the branch, we can re use the same. How do you set the title for a branch ( I'm sorry for the dumb question, but I wasn't able to see a button anywhere )

@Pranav2612000
Copy link
Contributor

Is something like this what you had in mind?
image

Things I need help with

  • Finalizing the algorithm to use. Not sure what's the best way to discuss this and get the opinion of a wider spectrum of users.
  • Text(Copy) for the config title
  • Text(Copy) for the config description
  • Do we need a Learn More like the above setting

Finalizing the algorithm is the most important part in my opinion. Once we have finalised it I can work up some proposals for the Config Title and Description ( If you have no specific standards it should stick to ) and we can iterate over them.

@Pranav2612000
Copy link
Contributor

@mtsgrd Bumping this up^^ 😅

@Byron Byron added enhancement An improvement to an existing feature UX/UI Focusing on user satisfaction, usability, and overall experience labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature UX/UI Focusing on user satisfaction, usability, and overall experience
Projects
None yet
Development

No branches or pull requests

4 participants