fix: Mitigate Prompt modal race condition #5326
Merged
+82
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the modal closing function a promise as it's done asynchronously. Add another optional callback that's called only in the case when clicking outside the modal.
Add some checks and await the handling of git prompts.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
estib-vega
force-pushed
the
fix-prompt-modal
branch
from
6c48f32
to
7a3d94b
Compare
estib-vega
force-pushed
the
fix-prompt-modal
branch
from
7a3d94b
to
2406720
Compare
mtsgrd
approved these changes
Oct 28, 2024
estib-vega
force-pushed
the
fix-prompt-modal
branch
from
2406720
to
4f672d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
This pull request addresses a race condition issue related to the Prompt modal.
🧢 Changes
Issue
As seen in #5258
Stacking
Depends on: #5325