Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a stack overview section to pr descriptions #5413

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

mtsgrd
Copy link
Contributor

@mtsgrd mtsgrd commented Nov 2, 2024

When stacking pull requests we append/update a stack list when creating a new pull request, and the total count is >= 2. On deleting a branch from a stack we close any associated pull request, and update the descriptions to exclude it.

This is part of a stack made with GitButler:

Copy link

vercel bot commented Nov 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
gitbutler-web ⬜️ Skipped (Inspect) Nov 8, 2024 11:44am

@mtsgrd mtsgrd force-pushed the pr-description-stack-table branch from abfcfaa to 26c9169 Compare November 2, 2024 16:53
@mtsgrd mtsgrd force-pushed the pr-description-stack-table branch from 26c9169 to c3a29c5 Compare November 2, 2024 17:02
@mtsgrd mtsgrd force-pushed the pr-description-stack-table branch from c3a29c5 to 6f41cb9 Compare November 2, 2024 17:11
@mtsgrd mtsgrd force-pushed the pr-description-stack-table branch from 6f41cb9 to 204d241 Compare November 2, 2024 17:45
@mtsgrd mtsgrd force-pushed the pr-description-stack-table branch from 204d241 to 4fef08b Compare November 4, 2024 21:28
@github-actions github-actions bot added the rust Pull requests that update Rust code label Nov 4, 2024
@mtsgrd mtsgrd force-pushed the pr-description-stack-table branch from 4fef08b to 21b7863 Compare November 6, 2024 20:04
@mtsgrd mtsgrd force-pushed the pr-description-stack-table branch from 21b7863 to 840f327 Compare November 6, 2024 20:32
@mtsgrd mtsgrd force-pushed the pr-description-stack-table branch from 840f327 to 47f2939 Compare November 6, 2024 21:39
@mtsgrd mtsgrd force-pushed the pr-description-stack-table branch from 47f2939 to 997648a Compare November 6, 2024 23:06
@mtsgrd mtsgrd force-pushed the pr-description-stack-table branch from 997648a to c4dc89e Compare November 6, 2024 23:20
@mtsgrd mtsgrd force-pushed the pr-description-stack-table branch from c4dc89e to 062d5f9 Compare November 7, 2024 11:04
@mtsgrd mtsgrd force-pushed the pr-description-stack-table branch from 062d5f9 to e30cdf9 Compare November 7, 2024 13:34
@mtsgrd mtsgrd marked this pull request as ready for review November 7, 2024 13:41
@mtsgrd mtsgrd changed the title Adds and updates footer in stacked pull request descriptions Add a stack overview section to pr descriptions Nov 7, 2024
@mtsgrd mtsgrd requested a review from PavelLaptev November 7, 2024 13:58
@mtsgrd
Copy link
Contributor Author

mtsgrd commented Nov 7, 2024

Thanks @Caleb-T-Owens. @PavelLaptev, let me know when you've had a chance to look at this!

@mtsgrd mtsgrd force-pushed the pr-description-stack-table branch from e30cdf9 to f9bc9e2 Compare November 7, 2024 16:39
Copy link
Contributor

@PavelLaptev PavelLaptev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mtsgrd! Looks good
Just made a few UI updates

@PavelLaptev
Copy link
Contributor

PavelLaptev commented Nov 8, 2024

If you don't mind, I also added a few things to the footer to improve readability.

image

@mtsgrd
Copy link
Contributor Author

mtsgrd commented Nov 8, 2024

Awesome, thank you.

@mtsgrd mtsgrd force-pushed the pr-description-stack-table branch from 10d6cdf to 670e576 Compare November 8, 2024 11:43
@mtsgrd mtsgrd merged commit c4aabb6 into master Nov 8, 2024
15 checks passed
@mtsgrd mtsgrd deleted the pr-description-stack-table branch November 8, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@gitbutler/desktop @gitbutler/ui rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants